Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate block cursor hack #39

Open
ghost opened this issue Feb 11, 2016 · 8 comments
Open

Eliminate block cursor hack #39

ghost opened this issue Feb 11, 2016 · 8 comments
Labels

Comments

@ghost
Copy link

ghost commented Feb 11, 2016

Version 0.10.8 has now has native support for a block cursor. (See microsoft/vscode PR #1586.)

ActionBlockCursor has a hack to simulate a block cursor. Unfortunately, toggling the block style is still not accessible through the extensions API. (See microsoft/vscode#561.) The implementation also has some minor aesthetic/readability issues. (See microsoft/vscode#2943.)

We can remove the hack now and recommend users toggle the editor.cursorStyle setting for themselves, or we can decide to wait for one or more of the outstanding issues to be resolved.

This issue can serve as a tracking bug.

@aioutecism
Copy link
Owner

I tried the new native block cursor and it makes the character under cursor hard to see.
I think we'd wait they solve the issue.

@ghost
Copy link
Author

ghost commented Feb 12, 2016

Yes, you may want to subscribe to microsoft/vscode#2943.

@holmeszyx
Copy link

may be able to refer to this sample from vscode.
https://github.com/alexandrudima/vscode-vim

@aioutecism
Copy link
Owner

@holmeszyx
The problem is the native block cursor makes the character under cursor hard to see.
The official sample shows how to change cursor style by extension, but not solving the visual problem.

@andradei
Copy link

vimStyle has the behavior the OP wants. But as @aioutecism, the character under cursor is hidden since the block cursor is opaque.

@asvetliakov
Copy link

asvetliakov commented May 15, 2016

latest code release should fix the opaque block cursor, so please make it native.
It's hard to tell which you mode in when cursor located at matched bracket pair

@shamrin
Copy link
Contributor

shamrin commented Jun 10, 2016

I think PR #103 is related to this issue.

@aioutecism
Copy link
Owner

I'm leaving this open until block cursor in visual mode is supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants