Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix with_suffix re-encoding entire name #1468

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

NTFSvolume
Copy link

@NTFSvolume NTFSvolume commented Feb 9, 2025

What do these changes do?

Make with_suffix only encode the new suffix instead of the entire name. The code is the same as with_name except that it only applies the quoter to the suffix, not the name.

Are there changes in behavior for the user?

Yes

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Feb 9, 2025
Copy link

codspeed-hq bot commented Feb 9, 2025

CodSpeed Performance Report

Merging #1468 will not alter performance

Comparing NTFSvolume:with_suffix_fix (f929f2e) with master (07c1b4f)

Summary

✅ 99 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

with_suffix always reencode entire name
1 participant