You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I understand this is open source software provided for free and that I might not receive a timely response.
I am positive I am NOT reporting a (potential) security
vulnerability, to the best of my knowledge. (These must be shared by
submitting this report form instead, if
any hesitation exists.)
I am willing to submit a pull request with reporoducers as xfailing test cases or even entire fix. (Assign this issue to me.)
Describe the bug
Calling with_suffix always re-encode the entire name. That's because with_suffix calls with_name under the hood, which always auto encodes
Please confirm the following
vulnerability, to the best of my knowledge. (These must be shared by
submitting this report form instead, if
any hesitation exists.)
Describe the bug
Calling
with_suffix
always re-encode the entire name. That's becausewith_suffix
callswith_name
under the hood, which always auto encodesfrom the method's description:
yarl/yarl/_url.py
Lines 1350 to 1354 in 07c1b4f
To Reproduce
Expected behavior
Only the suffix should be encoded (if needed) instead of the entire name.
Therefore, the expected result would be
https://domain.com/video%20file.avi
instead ofhttps://domain.com/video%2520file.avi
Logs/tracebacks
Python Version
multidict Version
propcache Version
yarl Version
OS
Windows 10
Additional context
No response
The text was updated successfully, but these errors were encountered: