Fix pool maxsize unlimited #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-ryzhykau
force-pushed
the
fix/pool-maxsize-unlimited
branch
from
f3e6486 to
22dd779
Compare
Codecov Report
@@ Coverage Diff @@
## master #426 +/- ##
==========================================
+ Coverage 92.69% 92.70% +0.01%
==========================================
Files 35 35
Lines 5432 5444 +12
Branches 586 588 +2
==========================================
+ Hits 5035 5047 +12
Misses 309 309
Partials 88 88
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Nothing4You
requested changes
Jan 28, 2022
There was a problem hiding this comment.
thank you for the PR.
effectively this PR should be porting aio-libs/aiopg#59
i've added another test case that fails on this PR, this change should be ported as well:
https://github.com/aio-libs/aiopg/pull/59/files#diff-34274c292424cfc2c3ac7e6a8a625f4d2cc652639b0bcaab02978bdf5bad6520R42
Nothing4You
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fix
pool.maxsizelogic to allow pool's size to be unlimited whenmaxsizeis 0.https://aiomysql.readthedocs.io/en/latest/pool.html#Pool
Are there changes in behavior for the user?
No changes.
Related issue number
#119
Checklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.