Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pool.maxsize = 0 does not allow unlimited connections #119

Closed
sseg opened this issue Oct 26, 2016 · 0 comments · Fixed by #426
Closed

Pool.maxsize = 0 does not allow unlimited connections #119

sseg opened this issue Oct 26, 2016 · 0 comments · Fixed by #426
Labels
bug
Milestone
0.1

Comments

@sseg
Copy link

sseg commented Oct 26, 2016

As noted in docs (https://github.com/aio-libs/aiomysql/blob/master/docs/pool.rst#L60):

If maxsize is 0 than size of pool is unlimited

A pool with maxsize = 0 ends up hanging on _acquire and never yielding a connection.

(aiomysql==0.0.9, Python 3.5.1)
@d-ryzhykau d-ryzhykau mentioned this issue Aug 11, 2019
Merged
4 tasks
@Nothing4You Nothing4You added this to the 1.0.0 milestone Jan 13, 2022
@Nothing4You Nothing4You linked a pull request Feb 2, 2022 that will close this issue
Fix pool maxsize unlimited #426
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.1
Development

Successfully merging a pull request may close this issue.

Fix pool maxsize unlimited d-ryzhykau/aiomysql
2 participants
@Nothing4You @sseg