Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #5649/4c663a2c backport][3.8] Fix pip upgrade on windows machines #5648 #5650

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Apr 26, 2021

This is a backport of PR #5649 as merged into master (4c663a2).

What do these changes do?

Possible fix for #5648.

Are there changes in behavior for the user?

No.

Related issue number

#5648

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@patchback patchback bot requested review from asvetlov and webknjaz as code owners April 26, 2021 11:10
@webknjaz webknjaz enabled auto-merge (squash) April 26, 2021 11:12
@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #5650 (4c663a2) into 3.8 (8ce3013) will decrease coverage by 0.35%.
The diff coverage is 97.04%.

❗ Current head 4c663a2 differs from pull request most recent head d991285. Consider uploading reports for the commit d991285 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              3.8    #5650      +/-   ##
==========================================
- Coverage   97.53%   97.17%   -0.36%     
==========================================
  Files          44       41       -3     
  Lines        8844     8865      +21     
  Branches     1424     1425       +1     
==========================================
- Hits         8626     8615      -11     
- Misses        102      133      +31     
- Partials      116      117       +1     
Flag Coverage Δ
unit 97.06% <96.78%> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/web_protocol.py 86.41% <ø> (-4.20%) ⬇️
aiohttp/web_request.py 95.99% <ø> (-1.57%) ⬇️
aiohttp/web_response.py 98.21% <ø> (-0.06%) ⬇️
aiohttp/web_routedef.py 98.13% <ø> (+0.03%) ⬆️
aiohttp/web_runner.py 97.74% <ø> (+0.11%) ⬆️
aiohttp/web_server.py 94.28% <ø> (-5.72%) ⬇️
aiohttp/web_urldispatcher.py 97.83% <ø> (+0.23%) ⬆️
aiohttp/worker.py 94.91% <ø> (-1.81%) ⬇️
aiohttp/locks.py 92.85% <66.66%> (ø)
aiohttp/resolver.py 93.33% <81.25%> (-1.83%) ⬇️
... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12645c9...d991285. Read the comment docs.

@webknjaz webknjaz merged commit 7914393 into 3.8 Apr 26, 2021
@webknjaz webknjaz deleted the patchback/backports/3.8/4c663a2c887d8a18e5f4220288e3324569e34b8b/pr-5649 branch April 26, 2021 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants