-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pip upgrade on windows machines #5648 #5649
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5649 +/- ##
==========================================
- Coverage 97.21% 97.17% -0.04%
==========================================
Files 41 41
Lines 8863 8865 +2
Branches 1425 1425
==========================================
- Hits 8616 8615 -1
- Misses 130 133 +3
Partials 117 117
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@@ -49,7 +49,7 @@ endif | |||
.SECONDARY: $(call to-hash,$(ALLS)) | |||
|
|||
.update-pip: | |||
@pip install -U 'pip' | |||
@python -m pip install --upgrade pip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this any different?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see what you mean. The log is here: https://github.com/aio-libs/aiohttp/pull/5647/checks?check_run_id=2435935600#step:6:14
Backport to 3.8: 💚 backport PR created✅ Backport PR branch: Backported as #5650 🤖 @patchback |
…5648 (#5650) (cherry picked from commit 4c663a2) Co-authored-by: Slava <[email protected]>
What do these changes do?
Possible fix for #5648.
Are there changes in behavior for the user?
No.
Related issue number
#5648
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.