Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove loop= param from asyncio.sleep() to fix tests on Python 3.10 #96

Merged
merged 2 commits into from
May 15, 2021
Merged

Remove loop= param from asyncio.sleep() to fix tests on Python 3.10 #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bc4e88
Remove loop= param from asyncio.sleep() to fix tests on Python 3.10
mgorny May 15, 2021
3538875
Enable testing on 3.10-dev
mgorny May 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,10 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-20.04, windows-2019, macos-10.15]
python-version: [ '3.6', '3.7', '3.8', '3.9', 'pypy-3.6', 'pypy-3.7' ]
python-version: [ '3.6', '3.7', '3.8', '3.9', '3.10-dev', 'pypy-3.6', 'pypy-3.7' ]
exclude:
- os: windows-2019
python-version: 3.10-dev
steps:
- uses: actions/checkout@v2
with:
Expand All @@ -19,6 +22,8 @@ jobs:
uses: actions/setup-python@v2
with:
python-version: ${{ matrix.python-version }}
- name: Install wheel
run: pip install wheel
- name: Build package
run: python setup.py install
- name: Run tests
Expand Down
2 changes: 1 addition & 1 deletion tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ def test_future_cancel(self):
f = self.resolver.query('google.com', 'A')
f.cancel()
async def coro():
await asyncio.sleep(0.1, loop=self.loop)
await asyncio.sleep(0.1)
await f
try:
self.loop.run_until_complete(coro())
Expand Down