Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove loop= param from asyncio.sleep() to fix tests on Python 3.10 #96

Merged
merged 2 commits into from
May 15, 2021

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented May 15, 2021

Fixes #95

@mgorny
Copy link
Contributor Author

mgorny commented May 15, 2021

I've also attempted enabling GHA testing on 3.10.

@saghul
Copy link
Contributor

saghul commented May 15, 2021

Looks like we need to install the wheel package to make sure building works.

@mgorny
Copy link
Contributor Author

mgorny commented May 15, 2021

Yeah, I'm guessing this is because either some of the low-level stuff (pip?) or GHA hasn't been yet all synced for 3.10 deprecations.

@mgorny
Copy link
Contributor Author

mgorny commented May 15, 2021

Windows seems to be unhappy but I don't really know how to fix it.

@saghul
Copy link
Contributor

saghul commented May 15, 2021

Let's exclude it for now. Linux and macOS pass, which is a good indication :-)

I think you can add a "excludes" section to the build matrix to skip 3.10 on Windows.

@mgorny
Copy link
Contributor Author

mgorny commented May 15, 2021

Let's try that but I think the wheel install stage could be causing the hangs on 3.8/3.9 jobs too.

@saghul saghul merged commit aac8df5 into aio-libs:master May 15, 2021
@saghul
Copy link
Contributor

saghul commented May 15, 2021

Not sure why Windows is getting stuck on Python 3.8/3.9 but that's not related to your PR. Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants