Add PEP484 Typing + typing to setup.py #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cooperlees
commented
Jan 5, 2017
cooperlees
commented
- Add in Py2/3 compatible PEP484 typing
- Add in typing as a install_requires in setup.py
saghul
reviewed
Jan 5, 2017
| self._channel.cancel() | ||
|
|
||
| # TODO: Workout socket fd type |
There was a problem hiding this comment.
Will change - Wasen't sure that it would always be an int
| @@ -103,7 +119,9 @@ def _sock_state_cb(self, fd, readable, writable): | |||
| self._timer.cancel() | |||
| self._timer = None | |||
|
|
|||
| # TODO: Workout socket fd type | |||
| @@ -6,7 +6,14 @@ | |||
| import trollius as asyncio | |||
| import pycares | |||
|
|
|||
| from . import error | |||
| from typing import ( | |||
There was a problem hiding this comment.
Sorry for my ignorance, but why are these needed if we are not really using them (just in comments) ?
There was a problem hiding this comment.
Those comments are evaluated by the tools performing the type checking (like mypy).
There was a problem hiding this comment.
| ) | ||
|
|
||
| # TODO: Work out mypy no attribute error | ||
| from . import error # type: ignore |
There was a problem hiding this comment.
Seems to be a mypy bug with this kind of import
- The import itself was already in the code
There was a problem hiding this comment.
@cooperlees What was the issue that you encountered? Seems to work fine with Python3 mypy, so I guess that this workaround should be removed.
|
Fixes coming |
|
Great work, cheers! |
|
No worries. Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.