Skip to content

.GITLAB: add UCX pkg-config to env #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
roiedanino wants to merge 1 commit into from
Closed

.GITLAB: add UCX pkg-config to env #518

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .gitlab/test_python.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,10 @@ set -x

# Parse commandline arguments with first argument being the install directory.
INSTALL_DIR=$1
UCX_INSTALL_DIR=$2

if [ -z "$INSTALL_DIR" ]; then
echo "Usage: $0 <install_dir>"
if [ -z "$INSTALL_DIR" ] || [ -z "$UCX_INSTALL_DIR" ]; then

@dpressle dpressle Jul 3, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default behavior today is to put both Nixl and UCX in same install dir which is how all build/tests scripts works today.
Your change forces us to provide both places even when it same place, i would have it as optional or you need to change all the places that calls this script (gitlab, aws, blossom etc)

echo "Usage: $0 <install_dir> <ucx_install_dir>"
exit 1
fi

Expand All @@ -35,7 +36,7 @@ export LD_LIBRARY_PATH=/usr/local/cuda/lib64:/usr/local/cuda/lib64/stubs:/usr/lo
export LD_LIBRARY_PATH=/usr/local/cuda/compat/lib.real:$LD_LIBRARY_PATH
export CPATH=${INSTALL_DIR}/include:$CPATH
export PATH=${INSTALL_DIR}/bin:$PATH
export PKG_CONFIG_PATH=${INSTALL_DIR}/lib/pkgconfig:$PKG_CONFIG_PATH
export PKG_CONFIG_PATH=${INSTALL_DIR}/lib/pkgconfig:${UCX_INSTALL_DIR}/lib/pkgconfig:$PKG_CONFIG_PATH
export NIXL_PLUGIN_DIR=${INSTALL_DIR}/lib/$ARCH-linux-gnu/plugins

pip3 install --break-system-packages .
Expand Down