.GITLAB: add UCX pkg-config to env - #518
Closed
roiedanino wants to merge 1 commit into
Closed
roiedanino wants to merge 1 commit into
roiedanino wants to merge 1 commit into
Conversation
Signed-off-by: Roie Danino <rdanino@nvidia.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds the UCX pkg-config directory to the environment in the test script to ensure Meson can find the UCX installation when building and running Python tests.
- Introduces a new argument (UCX_INSTALL_DIR) to the script.
- Updates the usage message and appends the UCX pkg-config directory to PKG_CONFIG_PATH.
Comments suppressed due to low confidence (1)
.gitlab/test_python.sh:22
- [nitpick] Consider adding an inline comment to clarify that UCX_INSTALL_DIR represents the installation directory of UCX, improving readability for future maintainers.
UCX_INSTALL_DIR=$2
|
👋 Hi roiedanino! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
Contributor
Author
|
/build |
dpressle
requested changes
Jul 3, 2025
|
|
||
| if [ -z "$INSTALL_DIR" ]; then | ||
| echo "Usage: $0 <install_dir>" | ||
| if [ -z "$INSTALL_DIR" ] || [ -z "$UCX_INSTALL_DIR" ]; then |
Contributor
There was a problem hiding this comment.
Default behavior today is to put both Nixl and UCX in same install dir which is how all build/tests scripts works today.
Your change forces us to provide both places even when it same place, i would have it as optional or you need to change all the places that calls this script (gitlab, aws, blossom etc)
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Add UCX pkg-config to path in test_python.sh
Why?
Otherwise meson can't find UCX when building and running python tests