Skip to content

Python: bindings optimizations and support numpy arrays for xfer_dlist - #439

Merged
pvijayakrish merged 5 commits into
mainfrom
yanivz/numpy_bindings
Jun 10, 2025
Merged

pvijayakrish merged 5 commits into
mainfrom
yanivz/numpy_bindings

Conversation

@mkhazraee

Copy link
Copy Markdown
Contributor

Speedup for 1M descriptor lists:

get_xfer_descs with numpy input: x3.7 vs list (82ms -> 22ms)
get_xfer_descs with list input: x1.3 (82ms -> 63ms)
get_reg_descs with numpy input: x2.7 vs get_reg_descs (146ms -> 54ms)
get_reg_descs with list input: x1.2 (146ms -> 122ms)
make_prepped_xfer with list: x1 (74ms -> 74ms)
make_prepped_xfer with numpy in: x1.7 vs list (74ms -> 44ms)

yanivz-nv and others added 2 commits June 6, 2025 10:05
#430)

* Python: bindings optimizations and support numpy arrays for xfer_dlist

Speedup for 1M descriptor lists:
* get_xfer_descs with numpy input: x3.7 vs list (82ms -> 22ms)
* get_xfer_descs with list input:  x1.3 (82ms -> 63ms)
* get_reg_descs with list input:   x1.2 (146ms -> 122ms)
* xferDList.pad() to regDList:     x2.7 vs get_reg_descs (146ms -> 54ms)
* make_prepped_xfer with list:     x1   (74ms -> 74ms)
* make_prepped_xfer with numpy in: x1.7 vs list (74ms -> 44ms)

Signed-off-by: Yaniv Zegerson <yanivz@nvidia.com>
@mkhazraee

Copy link
Copy Markdown
Contributor Author

/build

1 similar comment
@yosefe

yosefe commented Jun 8, 2025

Copy link
Copy Markdown
Contributor

/build

Comment thread src/api/python/_api.py
Comment thread test/python/prep_xfer_perf.py

@aranadive aranadive left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minus the comments

@roiedanino
roiedanino self-requested a review June 8, 2025 11:20
Comment thread examples/python/nixl_api_example.py
Comment thread src/api/python/_api.py
@aranadive

Copy link
Copy Markdown
Contributor

/build

1 similar comment
@yosefe

yosefe commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

/build

@aranadive

Copy link
Copy Markdown
Contributor

/ok to test bd0f5d7

@aranadive

Copy link
Copy Markdown
Contributor

/build

This branch was previously deployed

2 inactive deployments
GITLAB — 4f72025d Deployed Jun 9, 2025 by copy-pr-bot[bot]
SWX_AWS — 4f72025d Deployed Jun 9, 2025 by copy-pr-bot[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants