PLUGINS/UCX: Init only needed fields in UCP - 1.4.0 - #2022
nv-nmailhot merged 1 commit into
Conversation
|
👋 Hi iyastreb! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
|
/build |
|
🤖 CI Triage Agent — TL;DR: The "Run Nixlbench tests" stage was aborted after a ~48-minute hang (silence from 13:08:42 to 13:56:47), caused by the known-flaky UCCL nixlbench transfer test (issue #1999); the fix is to also skip the UCCL ASIO loop, which PR #2000 left enabled while only disabling the UCCL ETCD loop. Full analysisSummary: Jenkins stage "Run Nixlbench tests" (node 351) was ABORTED after wall-clock timeout because the first UCCL WRITE ASIO benchmark hung indefinitely. Root cause: Not a genuine slowness/time-budget issue — it's a hang. The last application output is Implicated commit: File: Suggested fix: Disable the UCCL ASIO benchmark loop the same way the ETCD one was disabled — wrap/comment out lines 95-103 with a reference to issue #1999 until the underlying UCCL hang is fixed. As a safety net, also wrap each Related: Issue #1999 (UCCL nixlbench test hangs); PR #2000 (incomplete skip).
|
|
🤖 CI Triage Agent — TL;DR: The Python test stage failed only against the UCX-master build: Full analysisSummary: Stage 318 ("Run Python tests", ucx-master variant) failed — Root cause: UCX backend instantiation degraded progressively during the run under UCX master. Timestamps show each Implicated commit: Not a nixl commit — the failing behavior tracks the UCX File: Test surface: Suggested fix: Treat the Related: none found (issue/PR search returned no matching reports for this timeout signature).
|
What?
Backport #2017 to v1.4.0
Why?
UCP SGL PR openucx/ucx#11258 increased the size of
request param, which is zero-initialized in NIXL on each operation. This extra
initialization costs 2% of performance in nixlbench (512Bx64000, 8 threads) on
EOS and DFW.
How?
We need to explicitly set only fields that we populate, no need to zero-init
the rest