CONTRIB: pin spcx-plugin to v0.2.x branch instead of master (v1.5.0 release) - #2014
Conversation
…elease) Signed-off-by: Roie Danino <rdanino@nvidia.com>
|
👋 Hi roiedanino! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe build container script changes the default UCX SPCX plugin reference from ChangesUCX SPCX plugin reference
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/build |
|
/build |
|
🤖 CI Triage Agent — TL;DR: The "Run Nixlbench tests" stage was killed (exit 143) after hanging ~24 minutes in UCCL backend teardown; the root cause is that PR #2000's skip of the flaky UCCL tests (issue #1999) was only applied to the ETCD-based block, leaving the ASIO-based UCCL block active — comment it out too. Full analysisSummary: Jenkins stage 299 ("Run Nixlbench tests", v1.22.x variant) was aborted with exit code 143 after the UCCL ASIO benchmark hung during engine shutdown. Root cause: A hang, not a slow test. The last application output was the UCCL READ/VRAM→VRAM benchmark printing its result at Implicated commit: 7a244b9 "CI: Skip UCCL nixlbench tests (#2000)" by ovidiusm (incomplete skip); the underlying hang is UCCL backend teardown per issue #1999. File: Suggested fix: Disable/comment out the ASIO UCCL block at lines 95–103 the same way the ETCD UCCL block (122–132) was, referencing issue #1999. As a defensive measure, also add a per-invocation timeout (e.g. wrap the Related: Issue #1999 (UCCL nixlbench test hangs); PR #2000 / commit 7a244b9 (partial skip). |
|
/ok to test c12fad7 |
The spcx section said the flag requires --dockerfile contrib/Dockerfile.manylinux, which this branch no longer enforces: the default contrib/Dockerfile consumes it too, and only the wheel bundling stays manylinux-only. Also correct the plugin ref default, which has been v0.2.x since ai-dynamo#2014. Signed-off-by: NirWolfer <nwolfer@nvidia.com>
The spcx section said the flag requires --dockerfile contrib/Dockerfile.manylinux, which this branch no longer enforces: the default contrib/Dockerfile consumes it too, and only the wheel bundling stays manylinux-only. Also correct the plugin ref default, which has been v0.2.x since ai-dynamo#2014. Signed-off-by: NirWolfer <nwolfer@nvidia.com>
What?
Change EXT plugin ref to v0.2.x release branch
Why?
Currently, it's pinned to master which aligned with UCX master while NIXL release uses v1.22.x,
v0.2.x branch of the plugin is aligned with UCX v1.22.x plugin API
Summary by CodeRabbit