Repository navigation
ci: Enable external contributor flow for NIXL repo - #143
Merged
Merged
Conversation
nvda-mesharma
approved these changes
Apr 10, 2025
Signed-off-by: Harrison Saturley-Hall <454891+saturley-hall@users.noreply.github.com>
tstamler
approved these changes
Apr 11, 2025
karya0
approved these changes
Apr 11, 2025
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NIXL's CI is currently inside the NVIDIA network and security protections require external contributions to be reviewed before they run on the internal network. Using
copy-pr-botwe are able to meet those security requirements.The bot examines the commits on the PR since branching from main checking for both commit author's membership in the ai-dynamo organization and for a signature that is verifiable (through it's registration on GitHub). In the event that both of those requirements are filled, you are on the happy path and no additional work is required.
If either of those verifications fails, GitLab CI will not run for that commit and will need to manually be triggered by a member of the ai-dynamo organization by adding a the comment
/ok to test.What do I have to do to be on the happy path?
Here are some instructions for setting up signed commits. Much is cribbed from GitHub's recommendations
Step 1) Generate your GPG key
🗒️ Save the password you enter here, you will need it for keyring authorization
Step 2) Get your GPG key id
This will generate something like below. In this example we will want to copy
ABCDCEF0123456789Step 3) Associate key with git user
Step 4) Export your public key
🗒️ Copy this public key block for use with GitHub
Step 5) Add your public key to GitHub
Step 5b) [optional] Turn on "Vigilant mode"
Step 6) Test sign a commit
It should prompt for you for your GPG password, enter the password used to create the GPG key in Step 1.
Step 7) Verify Functionality