Repository navigation
CONFIG: Part 2 (use). - #1346
Merged
Merged
Conversation
ColinNV
requested review from
a team,
akkart-aws,
amitrad-aws,
brminich,
fengjica,
gleon99,
yexiangd and
yosefe
as code owners
February 20, 2026 11:21
|
👋 Hi ColinNV! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
rakhmets
reviewed
Feb 20, 2026
Contributor
Author
|
/build |
brminich
reviewed
Feb 24, 2026
brminich
previously approved these changes
Feb 25, 2026
Contributor
|
/build |
Contributor
Author
|
/build |
Signed-off-by: Mikhail Brinskiy <brminich@users.noreply.github.com>
Contributor
|
/build |
Contributor
Author
|
/build |
Contributor
Author
|
/build |
brminich
previously approved these changes
Feb 27, 2026
Contributor
Author
|
/build |
yexiangd
previously approved these changes
Feb 27, 2026
yexiangd
left a comment
yexiangd
left a comment
Contributor
There was a problem hiding this comment.
Libfabric getenv API usage update looks good
Contributor
Author
|
/build |
guy-ealey-morag
approved these changes
Mar 2, 2026
brminich
approved these changes
Mar 2, 2026
yexiangd
approved these changes
Mar 2, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Consistently use the new config API from #1301.
Why?
Unify access to environment and prepare for config files.
How?
Replace all previous calls to
std::getenv()with the new API functions. Remember that conversion failures (a value exists in the environment (and later configuration file) but can't be converted to its target type) intentionally do not fall back to any default behaviour in order to not ((relativley) silently) hide mistakes in the setup.Summary by CodeRabbit
Refactor
Configuration Updates
Behavioral
Tests