Repository navigation
CONFIG: Part 1 (env, api). - #1301
Merged
Merged
Conversation
|
👋 Hi ColinNV! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
rakhmets
reviewed
Feb 10, 2026
brminich
reviewed
Feb 13, 2026
rakhmets
reviewed
Feb 13, 2026
Contributor
Author
|
/build |
rakhmets
previously approved these changes
Feb 16, 2026
Contributor
Author
|
/build |
Contributor
Author
|
/build |
1 similar comment
Contributor
|
/build |
brminich
approved these changes
Feb 20, 2026
This was referenced Feb 20, 2026
Merged
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Add new API for config access and implement for environment variables.
Why?
Unify access to environment and prepare for config files.
How?
This is the first PR with the API and environment access. It will be followed by a PR that implements config file reading, and one or more PRs that change all places in NIXL that call
getenv()(and similar) to use the new API.