Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
90ed9db
Add support to prepare Fifo
praveingk Jan 21, 2026
8a354ea
Fix errors
praveingk Jan 21, 2026
a9bcd2b
Add vector read/write support
praveingk Jan 22, 2026
8fd6a22
Use prepare fifo APIs
praveingk Jan 23, 2026
897f437
Remove RCMODE
praveingk Jan 23, 2026
5921a68
Remove rcmode in prepXfer
praveingk Jan 23, 2026
f03ee88
Remove rcmode from CI
praveingk Jan 23, 2026
76f8c81
Fix cleanup
praveingk Jan 23, 2026
e80c85b
Maintain a single transfer ID
praveingk Jan 28, 2026
047fd3c
Fix formatting
praveingk Jan 29, 2026
0438400
Fix formatting after changes
praveingk Jan 29, 2026
83a8eea
Remove redundant FIFO_ITEM_SIZE
praveingk Feb 3, 2026
d70747d
Update commit SHA of UCCL
praveingk Feb 3, 2026
92f0466
Remove unused variable
praveingk Feb 3, 2026
d276d72
Remove unused vars
praveingk Feb 3, 2026
800179b
Fix error
praveingk Feb 3, 2026
be118d1
Add recent updates to README
praveingk Feb 3, 2026
2f94415
Merge branch 'main' into one_sided_async
praveingk Feb 3, 2026
dc3d822
Fix copyright and format
praveingk Feb 3, 2026
c24e886
Merge branch 'one_sided_async' of github.com:praveingk/nixl into one_…
praveingk Feb 3, 2026
90d27cb
Increase CI image tag
praveingk Feb 3, 2026
facdff6
Use latest UCCL commit SHA
praveingk Feb 4, 2026
dbc0a46
Merge branch 'main' into one_sided_async
brminich Feb 5, 2026
8bcdc5a
Merge branch 'main' into one_sided_async
brminich Feb 10, 2026
3f081c2
Merge branch 'main' into one_sided_async
brminich Feb 11, 2026
1c9ae62
Merge branch 'main' into one_sided_async
brminich Feb 12, 2026
5b2fa0b
Merge branch 'main' into one_sided_async
brminich Feb 13, 2026
67aa7eb
Merge branch 'main' into one_sided_async
praveingk Feb 16, 2026
abda8a1
Merge branch 'main' into one_sided_async
brminich Feb 18, 2026
99df3d5
Add recent UCCL Commit
praveingk Feb 19, 2026
d956a79
Merge branch 'one_sided_async' of github.com:praveingk/nixl into one_…
praveingk Feb 19, 2026
8a05015
Merge branch 'main' into one_sided_async
praveingk Feb 20, 2026
b8fd08e
Merge branch 'main' into one_sided_async
praveingk Feb 24, 2026
d1e6536
Remove sleep during cleanup
praveingk Feb 24, 2026
ca02d54
Merge branch 'main' into one_sided_async
praveingk Feb 24, 2026
3144cf9
Add stop_accept API for graceful cleanup
praveingk Feb 25, 2026
867990b
Merge branch 'main' into one_sided_async
praveingk Feb 25, 2026
1bc2d51
Use CodeRabbit suggestions
praveingk Feb 26, 2026
1deed0d
Merge branch 'one_sided_async' of github.com:praveingk/nixl into one_…
praveingk Feb 26, 2026
7971222
Merge branch 'main' into one_sided_async
praveingk Feb 26, 2026
ca40dee
Add cleanup change to address crash
praveingk Feb 26, 2026
ea89faf
Merge branch 'one_sided_async' of github.com:praveingk/nixl into one_…
praveingk Feb 26, 2026
94e0564
Merge branch 'main' into one_sided_async
praveingk Feb 26, 2026
9cff793
Bump up the IMAGE_TAG
praveingk Feb 26, 2026
bb7b0a7
Revert CI_IMAGE_TAG
praveingk Feb 26, 2026
020ed23
Merge branch 'main' into one_sided_async
praveingk Feb 27, 2026
872e33a
Update IMAGE_TAG
praveingk Feb 27, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci/jenkins/lib/build-matrix.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ env:
TEST_TIMEOUT: 30
UCX_TLS: "^shm"
STORAGE_DRIVER: 'overlay'
CI_IMAGE_TAG: "20260219-1"
CI_IMAGE_TAG: "20260226-1"


runs_on_dockers:
Expand Down
2 changes: 1 addition & 1 deletion .ci/jenkins/lib/test-matrix.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ env:
SLURM_JOB_TIMEOUT: '02:20:00'
SLURM_IMMEDIATE_TIMEOUT: "3600"
STORAGE_DRIVER: overlay
CI_IMAGE_TAG: "20260219-1"
CI_IMAGE_TAG: "20260226-1"

empty_volumes:
- {mountPath: /var/lib/containers/storage, memory: false}
Expand Down
2 changes: 1 addition & 1 deletion .gitlab/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ LIBFABRIC_VERSION=${LIBFABRIC_VERSION:-v1.21.0}
# LIBFABRIC_INSTALL_DIR can be set via environment variable, defaults to INSTALL_DIR
LIBFABRIC_INSTALL_DIR=${LIBFABRIC_INSTALL_DIR:-$INSTALL_DIR}
# UCCL_COMMIT_SHA is the commit SHA of UCCL.
UCCL_COMMIT_SHA="a962f611021afc2e3c9358f6da4ae96539cbca0f"
UCCL_COMMIT_SHA="2de728f1a27ea3f3b66059baf838f940e243ebc6"
AZURITE_VER="3.35.0"
TMPDIR=$(mktemp -d)

Expand Down
2 changes: 1 addition & 1 deletion .gitlab/test_nixlbench.sh
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ if $HAS_GPU ; then
for op_type in READ WRITE; do
for initiator in $seg_types; do
for target in $seg_types; do
UCCL_RCMODE=1 run_nixlbench_two_workers --backend UCCL --op_type $op_type --initiator_seg_type $initiator --target_seg_type $target --check_consistency
run_nixlbench_two_workers --backend UCCL --op_type $op_type --initiator_seg_type $initiator --target_seg_type $target --check_consistency
done
done
done
Expand Down
3 changes: 3 additions & 0 deletions benchmark/nixlbench/src/worker/nixl/nixl_worker.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,9 @@ xferBenchNixlWorker::xferBenchNixlWorker(int *argc, char ***argv, std::vector<st
}

xferBenchNixlWorker::~xferBenchNixlWorker() {
delete rt;
rt = nullptr;

if (agent) {
delete agent;
agent = nullptr;
Expand Down
12 changes: 5 additions & 7 deletions src/plugins/uccl/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,20 +34,18 @@ UCCL engine would auto discover the right NIC to be used for the GPU based on th

Refer to [README](https://github.com/uccl-project/uccl/tree/main/collective/rdma#environment-variables-in-uccl) for the complete list of environment variables that can be set to customize UCCL.

**Important**: For `NIXL_READ` operations set `UCCL_RCMODE=1`. By default, UCCL uses RDMA UC (Unreliable Connection). However, `READ` operations need to operate on RDMA RC (Reliable Connection). `WRITE` operations can work on both RDMA UC and RC.

### Usage References

1) [NIXL Benchmark](https://github.com/uccl-project/uccl/blob/main/p2p/benchmarks/benchmark_nixl.py) in UCCL P2P: Refer to this [README](https://github.com/uccl-project/uccl/tree/main/p2p) on how to run the script.

2) [NIXL connector](https://github.com/vllm-project/vllm/commit/e731733d30d0aed3252dc60427927768bfc0ca73) in vLLM. vLLM's NIXL connector uses `NIXL_READ` operations, hence set env `UCCL_RCMODE` to 1.
2) [NIXL connector](https://github.com/vllm-project/vllm/commit/e731733d30d0aed3252dc60427927768bfc0ca73) in vLLM.

### Road Map

- [ ] Add Intra-node communication support
- Add asynchronous posting of reads over multiple workers to mitigate latency increase upon fragmentation

- [ ] Add Progress Thread support
- 🚧 Add Intra-node communication support

- [ ] Add asynchronous posting of reads over multiple workers to mitigate latency increase upon fragmentation
- 🚧 Add Progress Thread support

- [ ] Add support for other transport (TCP, TCP-X, etc.)
- 🚧 Add support for other transport (TCP, TCP-X, etc.)
Comment on lines +41 to +51

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Add a trailing newline to satisfy markdownlint (MD047).

📝 Suggested fix
- - 🚧 Add support for other transport (TCP, TCP-X, etc.)
+ - 🚧 Add support for other transport (TCP, TCP-X, etc.)
+
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
2) [NIXL connector](https://github.com/vllm-project/vllm/commit/e731733d30d0aed3252dc60427927768bfc0ca73) in vLLM.
### Road Map
- [ ] Add Intra-node communication support
- ✅ Add asynchronous posting of reads over multiple workers to mitigate latency increase upon fragmentation
- [ ] Add Progress Thread support
- 🚧 Add Intra-node communication support
- [ ] Add asynchronous posting of reads over multiple workers to mitigate latency increase upon fragmentation
- 🚧 Add Progress Thread support
- [ ] Add support for other transport (TCP, TCP-X, etc.)
\ No newline at end of file
- 🚧 Add support for other transport (TCP, TCP-X, etc.)
2) [NIXL connector](https://github.com/vllm-project/vllm/commit/e731733d30d0aed3252dc60427927768bfc0ca73) in vLLM.
### Road Map
- ✅ Add asynchronous posting of reads over multiple workers to mitigate latency increase upon fragmentation
- 🚧 Add Intra-node communication support
- 🚧 Add Progress Thread support
- 🚧 Add support for other transport (TCP, TCP-X, etc.)
🧰 Tools
🪛 markdownlint-cli2 (0.21.0)

[warning] 51-51: Files should end with a single newline character

(MD047, single-trailing-newline)

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/plugins/uccl/README.md` around lines 41 - 51, The file’s Markdown is
missing a trailing newline which triggers markdownlint MD047; open the README.md
and add a single blank newline at the end of the file so the final line (the
"Road Map" checklist / last checkbox line) is terminated by a newline character.

Loading