Repository navigation
libfabric: remove cm thread [Will squash before merge] - #1251
Merged
Merged
Conversation
added 3 commits
January 20, 2026 23:10
As the libfabric plugin moves away from EFA Direct to EFA protocol, it is not required to insert av addresses for target side. The code previously written for it, ie. a CM thread, is removed here. Signed-off-by: Feng Ji <fengnji@amazon.com>
fengjica
requested review from
akkart-aws,
amitrad-aws and
yexiangd
as code owners
January 26, 2026 21:20
|
👋 Hi fengjica! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
akkart-aws
reviewed
Jan 27, 2026
amitrad-aws
previously approved these changes
Jan 29, 2026
To kick off transfer. Otherwise later post send returns EAGAIN, and does backoff before retry.
fengjica
force-pushed
the
dev/remove_cm_thread
branch
2 times, most recently
from
January 29, 2026 23:18
77b9070 to
a7e1715
Compare
Contributor
|
/ok to test a7e1715 |
Contributor
|
/build |
yexiangd
approved these changes
Jan 30, 2026
yexiangd
left a comment
yexiangd
left a comment
Contributor
There was a problem hiding this comment.
Over all looks good! Do you mind updating the Libfabric plugin README?
fengjica
enabled auto-merge (squash)
February 3, 2026 06:43
mcuiaws
pushed a commit
to mcuiaws/nixl
that referenced
this pull request
Feb 3, 2026
* libfabric: remove CM thread As the libfabric plugin moves away from EFA Direct to EFA protocol, it is not required to insert av addresses for target side. The code previously written for it, ie. a CM thread, is removed here. The commit also did the following changes: * Remove posting shutdown to self. * Drive control rail progress in nixlLibfabricEngine deconstructor. * Remove enum value for CONNECTED, and also remove FAILED. * clang format fix * Drive control completion queue right after send to kick off transfer. Otherwise later post send returns EAGAIN, and does backoff before retry. --------- Signed-off-by: Feng Ji <fengnji@amazon.com> (cherry picked from commit 9e91adc)
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Remove CM thread.
Why?
CM thread is not needed any more. See the commit description for details.