Repository navigation
feat: make startup timeout configurable - #82
Merged
Merged
Conversation
Signed-off-by: Ziqi Fan <ziqif@nvidia.com>
This was referenced Oct 11, 2026
Collaborator
|
@ziqifan617 : Have you tried: |
ziqifan617
marked this pull request as ready for review
October 12, 2026 18:00
Signed-off-by: Ziqi Fan <ziqif@nvidia.com>
ziqifan617
force-pushed
the
codex/glm53-hicache-startup-budget
branch
from
October 12, 2026 18:01
3d265d1 to
4dbf52f
Compare
Contributor
Author
Thanks @karya0 , I haven't. Will give it a shot when I have the hw to try it again. for your suggestion, codex gives below concers:
But overall, I had met a few times that the registration is slow somehow so exposing it out for future sake as well. WDYT? |
Signed-off-by: Ziqi Fan <ziqif@nvidia.com>
Signed-off-by: Ziqi Fan <ziqif@nvidia.com>
mkhazraee
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the existing KVCR startup timeout configurable per instance via
KVCRConfig.startup_timeout_seconds, allowing longer waits for large memory registrations.Nonepreserves the 30-second default; explicit values must be positive integers. The option applies to the localprepare()andstart()waits only, without changing transfer deadlines or requiring matching values across nodes.