Repository navigation
Pin the vLLM quick start to a Dynamo revision that imports on the pinned vLLM nightly - #160
Merged
Merged
Conversation
…ned vLLM nightly Signed-off-by: doxu <doxu@nvidia.com>
mkhazraee
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Dockerfile.quick-start-vllmpins Dynamo v1.6.0 (701da25) with vLLM nightlyedad8b03. Every worker built from it exits at import (cannot import name 'get_engine_zmq_addresses'), so the quick start cannot start a worker (Dockerfile.quick-start-vllm (v0.2.0): pinned Dynamo v1.6.0 cannot import on the pinned vLLM nightly #159).dynamo.vllmbut not the worker entry point, so the mismatch passes the build.Fix
DYNAMO_REF→318ab039(Dynamo main, 2026-11-02). Dynamo dropped the renamed import on 2026-10-23 (build(vllm): bump core to v0.32.0 and Omni to v0.32.0rc1 dynamo#16757); v1.6.0 and v1.6.1 both still have it.VLLM_IMAGEandKVCR_VLLM_REFare unchanged.import dynamo.vllm.main, so a Dynamo/vLLM pair that cannot start a worker fails the build instead of the firstpython -m dynamo.vllm.Validation
ghcr.io/luckyq/kvcr-phase1:qs-218c7816b34b, 7 min); the new import check passes.source_write == remote_deliver, 0 token mismatches).Fixes #159.