Skip to content

test: Phase 1 TC-02 local DRAM flow and TC-03 hinted peer transfer - #138

Draft
luckyq wants to merge 1 commit into
doxu/phase1-1-core-tc01from
doxu/phase1-2-tc02-tc03
Draft

luckyq wants to merge 1 commit into
doxu/phase1-1-core-tc01from
doxu/phase1-2-tc02-tc03

Conversation

@luckyq

@luckyq luckyq commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

Series map (Phase 1 harness, one PR per step; each is based on the previous one)

PR Step Test cases
#137 Harness core: stack, client, telemetry, reference engine, CI unit tests; phase1 job in vllm-e2e.yml on the two-GPU runner (TC-01; #138/#139 extend --cases) TC-01 integration generation correctness
#138 Local DRAM flow and hinted peer transfer, hybrid geometry flags TC-02, TC-03
#139 Guard protection, takeover, replacement TC-04
#140 Streaming client, performance arms, Guard recovery timing TC-05, TC-06
#141 Sidecar kvcr_service, 2P+1D, two nodes, k8s / Slurm / Docker runners; phase1-2p1d CI job (2P+1D on the two-GPU runner, prefill workers share GPU 0) all cases on those topologies
#142 docs/ci.md: what the two CI lanes verify, how to run them elsewhere, how to read evidence —
#143 Test plan, run history, bare-vLLM probes —
#180 --engine sglang: dynamo.sglang + HiCache KVCR storage backend (quick-start config), SGLang telemetry mapping, deterministic mode; no Guard/disagg TC-01..03, TC-05 on SGLang

Replaces #103. All seven are drafts until the per-PR GPU runs on the current main image are done.

Problem

  • Part 2 of the stacked Phase 1 series (on top of the core + TC-01 PR). The harness so far proves only that a worker reuses its own KVCR tier; the local DRAM flow with partial prefixes and the router-hint peer transfer are untested.

What this adds

  • TC-02 local DRAM full flow: full prompt, partial-prefix prompt, absent prompt; the hit length is checked against what the KVCR-disabled reference engine itself could reuse, with the hybrid-model arms (--tc02-seed-prefix, --tc02-extra-shared-sections, --tc02-evict-target) that exposed the SSM-checkpoint over-transfer (dynamo#16794).
  • TC-03 request hints and peer transfer: a hinted and a fresh request reach worker 1 together; the hinted one hits with remote_deliver == source_write == hit blocks and equal bytes, the fresh one is cold; no failed/partial KVCR metrics.
  • Hybrid geometry flags --hit-block-tokens 576 --ssm-groups 3 --page-bytes 18874368 (Qwen3.5-4B) make the delivered-pages and bytes checks exact; without them they are lower bounds.
  • Unit tests: prompt prefix layout, expected hit blocks, missing-SSM-pages verdict.

Validation

@copy-pr-bot

copy-pr-bot Bot commented Oct 27, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@luckyq
luckyq marked this pull request as draft October 27, 2026 19:33
@luckyq
luckyq force-pushed the doxu/phase1-2-tc02-tc03 branch from f20b123 to bb0a28a Compare November 2, 2026 07:38
@luckyq
luckyq force-pushed the doxu/phase1-1-core-tc01 branch from 655100f to 3869555 Compare November 2, 2026 07:38
@luckyq
luckyq force-pushed the doxu/phase1-2-tc02-tc03 branch from bb0a28a to 7904813 Compare November 2, 2026 22:44
@luckyq
luckyq force-pushed the doxu/phase1-1-core-tc01 branch 2 times, most recently from 175a5ab to e561643 Compare November 2, 2026 23:15
@luckyq
luckyq force-pushed the doxu/phase1-2-tc02-tc03 branch 2 times, most recently from 4cfd6ec to d9ee671 Compare November 2, 2026 23:17
@luckyq
luckyq force-pushed the doxu/phase1-1-core-tc01 branch 2 times, most recently from a4ed8e6 to d4653da Compare November 2, 2026 23:53
@luckyq
luckyq force-pushed the doxu/phase1-2-tc02-tc03 branch 2 times, most recently from 7227285 to 68fc775 Compare November 3, 2026 18:18
@luckyq
luckyq force-pushed the doxu/phase1-1-core-tc01 branch 2 times, most recently from 0a6e258 to 7e1ab4b Compare November 3, 2026 19:45
@luckyq
luckyq force-pushed the doxu/phase1-2-tc02-tc03 branch 2 times, most recently from 581817a to e271a47 Compare November 3, 2026 19:46
@luckyq
luckyq force-pushed the doxu/phase1-1-core-tc01 branch from 7e1ab4b to f93e820 Compare November 3, 2026 19:46
@luckyq
luckyq force-pushed the doxu/phase1-2-tc02-tc03 branch from e271a47 to c4a824b Compare November 3, 2026 20:22
@luckyq
luckyq force-pushed the doxu/phase1-1-core-tc01 branch from f93e820 to df3dd9e Compare November 3, 2026 20:22
TC-02 checks the full, partial-prefix and absent prompts against what the
KVCR-disabled reference engine itself reuses, with the hybrid-model arms
(seeded prefix, extra shared sections, eviction) that measured the SSM
checkpoint over-transfer. TC-03 sends a hinted and a fresh request to the
target together: the hinted one hits with remote_deliver == source_write ==
hit blocks and equal bytes, the fresh one stays cold. Hybrid geometry flags
(--hit-block-tokens, --ssm-groups, --page-bytes) make the page and byte
checks exact.

Part 2 of the stacked Phase 1 series.

Signed-off-by: doxu <doxu@nvidia.com>
@luckyq
luckyq force-pushed the doxu/phase1-2-tc02-tc03 branch from c4a824b to 6d2442f Compare November 4, 2026 01:14
@luckyq
luckyq force-pushed the doxu/phase1-1-core-tc01 branch from df3dd9e to 486699f Compare November 4, 2026 01:14

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant