Repository navigation
Conversation
luckyq
force-pushed
the
doxu/phase1-1-core-tc01
branch
from
October 27, 2026 19:09
54fa70e to
655100f
Compare
luckyq
marked this pull request as draft
October 27, 2026 19:33
This was referenced Oct 27, 2026
luckyq
force-pushed
the
doxu/phase1-1-core-tc01
branch
9 times, most recently
from
November 3, 2026 20:22
f93e820 to
df3dd9e
Compare
Brings up a Dynamo KV router, two vLLM workers with KVCR tiers and kvcr_service Guard sidecars on two GPUs, runs a KVCR-disabled reference engine first, and checks TC-01 (cold request commits to the KVCR tier, the repeat is a block-aligned hit) with every answer compared token by token to the reference. Evidence is result.json, JUnit and per-request files. Part 1 of the stacked Phase 1 series; later parts add TC-02..06, disaggregated and two-node topologies, the CI job and the test plan. CI now runs tests/ci next to tests/unit. Signed-off-by: doxu <doxu@nvidia.com>
luckyq
force-pushed
the
doxu/phase1-1-core-tc01
branch
from
November 4, 2026 01:14
df3dd9e to
486699f
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Series map (Phase 1 harness, one PR per step; each is based on the previous one)
phase1job invllm-e2e.ymlon the two-GPU runner (TC-01; #138/#139 extend--cases)kvcr_service, 2P+1D, two nodes, k8s / Slurm / Docker runners;phase1-2p1dCI job (2P+1D on the two-GPU runner, prefill workers share GPU 0)docs/ci.md: what the two CI lanes verify, how to run them elsewhere, how to read evidence--engine sglang: dynamo.sglang + HiCache KVCR storage backend (quick-start config), SGLang telemetry mapping, deterministic mode; no Guard/disaggReplaces #103. All seven are drafts until the per-PR GPU runs on the current main image are done.
Problem
What this adds
tests/e2e/run_phase1.py+tests/e2e/phase1/: brings up a Dynamo frontend (KV router), two vLLM workers with KVCR tiers andkvcr_serviceGuard sidecars on two GPUs; runs a KVCR-disabled reference engine first (tokens must reproduce, worker log must be KVCR-free); every request's tokens are compared with the reference; KVCR telemetry is parsed from the vLLM metrics log; evidence isresult.json+ JUnit + per-request files. The service launcher pickskvcr.service.server(KVCR 0.2.0) orkvcr.kvcr_service(earlier releases) by what the installed package provides.phase1job appended to.github/workflows/vllm-e2e.yml: afterpeer-transfer, same ECR image andprod-kvcr-tester-amd-gpu-2-v1runner,run_phase1.py --mode guard --cases TC-01, evidence uploaded as an artifact. Each later part widens--casesto the cases it adds, so every PR in the series is gated on the GPU runner.local_fill), the repeat is a block-aligned hit with no failed/partial KVCR metrics.tests/ci/test_phase1.py: 21 CPU unit tests (telemetry parsing, token comparison, verdicts, arguments, tier configs);ci.ymlnow runstests/cinext totests/unit.Validation
ruff check src tests,ruff format --check,pytest tests/ci: 21 passed (run on a cluster login node, not locally).Notes
src/.