Skip to content

fix(release)!: publish parser and renderer against protocols 8 - #375

Merged
rmccorm4 merged 1 commit into
mainfrom
rmccormick/release-protocol8-dependents
Oct 8, 2026
Merged

rmccorm4 merged 1 commit into
mainfrom
rmccormick/release-protocol8-dependents

Conversation

@rmccorm4

@rmccorm4 rmccorm4 commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The published renderer and v1 parser still depend on dynamo-protocols 7.x, so downstream consumers cannot share their public protocol types with protocols 8.0.0. The workspace already uses protocols 8.0.0, but those dependent crates have not been released with that requirement.

Peg dynamo-parsers at 10.0.0 and dynamo-renderer at 8.0.0, update the workspace version references and lockfile, and document the breaking dependency change. Both crates expose protocol types in their public APIs, so these are major bumps. The existing release workflow recognizes the manual versions and publishes them after merge. No Rust source changes.

Follow-up to #322; supplies the compatible releases needed by ai-dynamo/dynamo#15547. Dynamo still needs its separate API migration before that dependency upgrade can compile.

Internal tracking: DIS-3038, assigned to Ryan McCormick.

Validation

  • cargo test -p dynamo-protocols -p dynamo-parsers -p dynamo-renderer --locked: 1,459 passed, 9 ignored.
  • cargo clippy -p dynamo-protocols -p dynamo-parsers -p dynamo-renderer --all-targets --all-features --locked -- -D warnings: passed.
  • cargo publish --dry-run --locked --allow-dirty -p dynamo-parsers -p dynamo-renderer: passed for both crates against registry dependencies; nothing published.
  • Verified both normalized package manifests contain dynamo-protocols version 8.0.0 without a path override.
  • Release workflow semver gate: cargo semver-checks check-release passed for each crate against its last release tag; both manual bumps are major releases.
  • cargo fmt --all -- --check and git diff --check: passed.

Signed-off-by: Ryan McCormick <rmccormick@nvidia.com>
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown

📊 Conformance matrix rendered — view in CI summary

@rmccorm4
rmccorm4 marked this pull request as ready for review October 8, 2026 22:03
@rmccorm4
rmccorm4 requested a review from a team as a code owner October 8, 2026 22:03

@luckyq luckyq left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Versions are consistent across workspace Cargo.toml, crate manifests, Cargo.lock, and changelogs. parsers/v1 and renderer are the only published crates that depend on protocols, so nothing is missed.

@luckyq
luckyq requested a review from a team October 8, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants