Repository navigation
fix(release)!: publish parser and renderer against protocols 8 - #375
Merged
Merged
Conversation
Signed-off-by: Ryan McCormick <rmccormick@nvidia.com>
|
📊 Conformance matrix rendered — view in CI summary |
rmccorm4
marked this pull request as ready for review
October 8, 2026 22:03
luckyq
approved these changes
Oct 8, 2026
luckyq
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Versions are consistent across workspace Cargo.toml, crate manifests, Cargo.lock, and changelogs. parsers/v1 and renderer are the only published crates that depend on protocols, so nothing is missed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The published renderer and v1 parser still depend on
dynamo-protocols7.x, so downstream consumers cannot share their public protocol types with protocols 8.0.0. The workspace already uses protocols 8.0.0, but those dependent crates have not been released with that requirement.Peg
dynamo-parsersat 10.0.0 anddynamo-rendererat 8.0.0, update the workspace version references and lockfile, and document the breaking dependency change. Both crates expose protocol types in their public APIs, so these are major bumps. The existing release workflow recognizes the manual versions and publishes them after merge. No Rust source changes.Follow-up to #322; supplies the compatible releases needed by ai-dynamo/dynamo#15547. Dynamo still needs its separate API migration before that dependency upgrade can compile.
Internal tracking: DIS-3038, assigned to Ryan McCormick.
Validation
cargo test -p dynamo-protocols -p dynamo-parsers -p dynamo-renderer --locked: 1,459 passed, 9 ignored.cargo clippy -p dynamo-protocols -p dynamo-parsers -p dynamo-renderer --all-targets --all-features --locked -- -D warnings: passed.cargo publish --dry-run --locked --allow-dirty -p dynamo-parsers -p dynamo-renderer: passed for both crates against registry dependencies; nothing published.dynamo-protocolsversion8.0.0without a path override.cargo semver-checks check-releasepassed for each crate against its last release tag; both manual bumps are major releases.cargo fmt --all -- --checkandgit diff --check: passed.