Repository navigation
fix(protocols): preserve Anthropic tool strict - #322
Merged
Merged
Conversation
Signed-off-by: Ryan McCormick <rmccormick@nvidia.com>
rmccorm4
marked this pull request as ready for review
October 2, 2026 04:15
rmccorm4
enabled auto-merge (squash)
October 2, 2026 04:15
![dynamo-review-agent[bot]](https://avatars.githubusercontent.com/u/201626793?s=60&v=4){kind=small}
rmccorm4
changed the title
rmccorm4
changed the title
luckyq
self-requested a review
October 8, 2026 20:38
luckyq
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Anthropic tools containing
strict: truelose the flag during deserialization. AddAnthropicTool.strict: Option<bool>so explicit true/false values survive serialization and an omitted value stays omitted. The companion Dynamo change (ai-dynamo/dynamo#15547) forwards this field toChatCompletionTool.function.strict.Relates to #320.
Internal tracking: DIS-3038.
Validation
cargo test -p dynamo-protocols --locked: 156 tests passed.cargo fmt --all -- --checkandgit diff --checkpassed.