Skip to content

fix(vllm-tests): skip omni test collection when vllm_omni is missing #9406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
krishung5 wants to merge 1 commit into from
Closed

fix(vllm-tests): skip omni test collection when vllm_omni is missing #9406

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions components/src/dynamo/vllm/tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,15 @@ def pytest_ignore_collect(collection_path, config):
if filename.startswith("test_vllm_"):
if importlib.util.find_spec("vllm") is None:
return True # vllm not available, skip this file
# Omni tests import dynamo.vllm.omni.* which transitively imports
# vllm_omni at module load — that import raises on platforms vllm_omni
# doesn't support (e.g. CPU-only sample-runtime runners), and the
# exception type isn't always ImportError so each file's local
# try/except guard isn't enough.
parts = collection_path.parts
if "omni" in parts and filename.startswith("test_"):
if importlib.util.find_spec("vllm_omni") is None:
return True
return None


Expand Down
Loading