fix(vllm-tests): skip omni test collection when vllm_omni is missing - #9406
fix(vllm-tests): skip omni test collection when vllm_omni is missing#9406krishung5 wants to merge 1 commit into
Conversation
The sample-unified-test CPU runner imports test_*.py files in the vllm/omni/ tree during pytest collection, which triggers a vllm_omni import that fails on platforms vllm_omni doesn't support. Extend the existing pytest_ignore_collect guard in vllm/tests/conftest.py to also cover omni/ files when vllm_omni isn't importable. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe ChangesTest Collection Skip Logic
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Folded into #9407 — single PR is easier to land since both fixes are needed for main to build + sample-runtime to pass. |
Summary
sample-runtime / Unified Test cuda12.9, amd64CI job (.github/workflows/pr.yaml:479) has been failing on every PR that toucheslib/**or other paths that triggerchanged-files.outputs.core. The job runspytest -m "pre_merge and gpu_0 and unified"on a CPU-only runner with no test-path filter, so pytest walks the whole repo and imports everytest_*.pyit finds before filtering by marker.components/src/dynamo/vllm/tests/omni/test_*.pyfiles transitively importvllm_omniat module-load time.vllm_omniisn't installed in the sample-runtime image (and on CPU-only platforms the import can raise something other thanImportError), so the per-filetry/except ImportError: pytest.skip(...)guard inside each test file doesn't always catch it.pytest_ignore_collectguard incomponents/src/dynamo/vllm/tests/conftest.pythat skipstest_vllm_*.pyfiles whenvllmisn't importable. This PR extends that same hook to also skip any file under anomni/directory whenvllm_omniisn't importable.Test plan
sample-runtime / Unified Test cuda12.9, amd64job passes on this PR (it has been failing on PRs that touchcore-changed files)vllm_omniinstalled — omni tests still get collected and run🤖 Generated with Claude Code
Summary by CodeRabbit