Repository navigation
feat(serve): Enhance multi-node deployment and worker configuration - #457
Merged
Merged
Conversation
ishandhanani
requested review from
GuanLuo,
PeaBrane,
alec-flowers,
biswapanda,
grahamking,
hhzhang16,
hutm,
julienmancuso,
kkranen,
mohammedabdulwahhab,
nnshah1,
paulhendricks,
piotrm-nvidia,
ptarasiewiczNV,
rmccorm4,
ryanolson,
sshchoi,
tanmayv25,
tedzhouhk and
tmonty12
as code owners
April 1, 2025 01:39
tlipoca9
suggested changes
Apr 1, 2025
tlipoca9
left a comment
tlipoca9
left a comment
Contributor
There was a problem hiding this comment.
the change of disagg_router.yaml is unnecessary.
ryanolson
reviewed
Apr 1, 2025
tlipoca9
reviewed
Apr 1, 2025
ishandhanani
enabled auto-merge (squash)
April 1, 2025 18:05
PeaBrane
approved these changes
Apr 1, 2025
hutm
reviewed
Apr 1, 2025
nnshah1
reviewed
Apr 1, 2025
nnshah1
reviewed
Apr 1, 2025
nnshah1
reviewed
Apr 1, 2025
nnshah1
reviewed
Apr 1, 2025
nnshah1
reviewed
Apr 1, 2025
mohammedabdulwahhab
left a comment
mohammedabdulwahhab
left a comment
Contributor
There was a problem hiding this comment.
Agreed with @hutm that we need to clean up the different ways env, flags, and config are manipulated in serving.py. But that can come as part of a later follow up.
mohammedabdulwahhab
approved these changes
Apr 1, 2025
nnshah1
reviewed
Apr 2, 2025
| if worker_envs: | ||
| args.extend(["--worker-env", json.dumps(worker_envs)]) | ||
| if resource_envs: | ||
| args.extend(["--worker-env", json.dumps(resource_envs)]) |
Contributor
There was a problem hiding this comment.
@mohammedabdulwahhab , @ishandhanani - still a little confused on the plural here, we are passing the full list of resource_envs to a variable that is worker-env -> singular - is that right?
its the full list for all workers that we pass here to a single process? - is this a global watcher watching all workers?
kylehh
pushed a commit
to kylehh/dynamo
that referenced
this pull request
Apr 11, 2025
…i-dynamo#457) Co-authored-by: hongkuanz <hongkuanz@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
dynamo serveto allow individual components to accept flags/configsuvloop.install()back in. We used to have it in all of our old examples (see here)Details:
cc: #428 by @tlipoca9