You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
👋 Hi tlipoca9! Thank you for contributing to ai-dynamo/dynamo.
Just a reminder: The NVIDIA Test Github Validation CI runs an essential subset of the testing framework to quickly catch errors.Your PR reviewers may elect to test the changes comprehensively before approving your changes.
I plan to get to this tomorrow but instead of having a sed command - what do you think of having some clear documentation around how to deploy this? Something like
Node 1
We spin up NATS and ETCD and spin up the Frontend, Processor, and Router.
Have a file (or just explain that you need to run Frontend.link(Processor).link(Router)
Node 2
Here we run the workers (prefill and decode)
Export the NATS and ETCD env vars
Have a file (or again just explain that you need to run VllmWorker.link(PrefillWorker)
Let me create a PR for this tomorrow and tag you in case you want to take a look
I plan to get to this tomorrow but instead of having a sed command - what do you think of having some clear documentation around how to deploy this? Something like
Node 1
We spin up NATS and ETCD and spin up the Frontend, Processor, and Router.
Have a file (or just explain that you need to run Frontend.link(Processor).link(Router)
Node 2
Here we run the workers (prefill and decode)
Export the NATS and ETCD env vars
Have a file (or again just explain that you need to run VllmWorker.link(PrefillWorker)
Let me create a PR for this tomorrow and tag you in case you want to take a look
Thanks for your reply !
I think a clear documentation guides how to use dynamo to deploy PD disaggregation with mutli nodes is helpful.
Could we explicitly separate the Prefill Worker and VLLM Worker deployments on Node 2? This would clearly show the guide can used by PD disaggregation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview:
add a example to serve llm with multi node
Related Issues: