Skip to content

chore: Fix cuda lock in trtllm dockerfile (#3684) #3704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saturley-hall merged 1 commit into from
Oct 17, 2025
Merged

chore: Fix cuda lock in trtllm dockerfile (#3684) #3704

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions container/Dockerfile.trtllm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,9 @@ ARG TENSORRTLLM_INDEX_URL
COPY --from=trtllm_wheel /*.whl /trtllm_wheel/
COPY --from=trtllm_wheel /*.txt /trtllm_wheel/

# NOTE: locking cuda-python version to <13 to avoid breaks with tensorrt-llm 1.0.0rc6.
Copy link
Copy Markdown
Member

@saturley-hall saturley-hall Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment has me confused as we are currently using tensorrt-llm 1.1.0rc5. I see on main that Ryan left a comment asking for a different note but only after he approved. I am going to take this but please fix that on main

RUN uv pip install "cuda-python>=12,<13"

# Note: TensorRT needs to be uninstalled before installing the TRTLLM wheel
# because there might be mismatched versions of TensorRT between the NGC PyTorch
# and the TRTLLM wheel.
Expand Down
Loading