chore: Fix cuda lock in trtllm dockerfile (#3684)#3704
Merged
Conversation
Signed-off-by: Indrajit Bhosale <iamindrajitb@gmail.com>
| COPY --from=trtllm_wheel /*.whl /trtllm_wheel/ | ||
| COPY --from=trtllm_wheel /*.txt /trtllm_wheel/ | ||
|
|
||
| # NOTE: locking cuda-python version to <13 to avoid breaks with tensorrt-llm 1.0.0rc6. |
Member
There was a problem hiding this comment.
This comment has me confused as we are currently using tensorrt-llm 1.1.0rc5. I see on main that Ryan left a comment asking for a different note but only after he approved. I am going to take this but please fix that on main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview:
Cherrypick
2c2f7c7d0b17d758a1e260e9525aa77e36ab1993