-
Notifications
You must be signed in to change notification settings - Fork 647
chore: move jail stream readme #3509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: ayushag <[email protected]>
WalkthroughAdded an SPDX/Apache-2.0 license header and initial documentation content (Overview) for the JailedStream Implementation in a single guide file. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: ayushag <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving just to get it out of top-level directory
For final destination, CC @athreesh @kmkelle-nv - this is more like dynamo rust developer documentation than user documentation. Where is a good bucket for these types of things for docs UX efforts?
I think the Slurm guides are similar in that they're useful to developers, but not necessarily intended for majority of end users. CC @hutm
@ayushag-nv to fix the failing doc generation check:
I think you need to add dynamo/docs/hidden_toctree.rst Line 39 in 8388e16
|
Overview:
Move jail stream readme from top level to docs
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit