feat: expose KV routing components for easier router customization #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuanLuo
requested review from
biswapanda,
grahamking,
nnshah1,
paulhendricks,
ptarasiewiczNV and
rmccorm4
as code owners
Test Results 2 files 2 suites 55s ⏱️ Results for commit 51e3267. ♻️ This comment has been updated with latest results. |
nnshah1
reviewed
Mar 4, 2025
alec-flowers
reviewed
Mar 5, 2025
alec-flowers
reviewed
Mar 5, 2025
alec-flowers
reviewed
Mar 5, 2025
alec-flowers
reviewed
Mar 5, 2025
alec-flowers
reviewed
Mar 5, 2025
alec-flowers
reviewed
Mar 5, 2025
alec-flowers
reviewed
Mar 5, 2025
alec-flowers
reviewed
Mar 5, 2025
alec-flowers
reviewed
Mar 5, 2025
alec-flowers
reviewed
Mar 5, 2025
alec-flowers
reviewed
Mar 5, 2025
alec-flowers
reviewed
Mar 5, 2025
alec-flowers
reviewed
Mar 5, 2025
There was a problem hiding this comment.
Should this be a warning?
There was a problem hiding this comment.
tracing doesn't have warning level
There was a problem hiding this comment.
alec-flowers
reviewed
Mar 5, 2025
alec-flowers
reviewed
Mar 5, 2025
alec-flowers
reviewed
Mar 5, 2025
alec-flowers
requested changes
Mar 5, 2025
alec-flowers
approved these changes
Mar 5, 2025
nnshah1
approved these changes
Mar 5, 2025
rmccorm4
reviewed
Mar 6, 2025
| tokio::spawn(async move { | ||
| while let Some(event) = kv_events_rx.next().await { | ||
| let event: llm_rs::kv_router::indexer::RouterEvent = | ||
| serde_json::from_slice(&event.payload).unwrap(); |
There was a problem hiding this comment.
We should avoid unwrap() - this will panic and crash if deserialization of the event fails.
There was a problem hiding this comment.
@GuanLuo , @alec-flowers - can you fix?
rmccorm4
reviewed
Mar 6, 2025
| .map(|s| Endpoint { | ||
| name: s.name, | ||
| subject: s.subject, | ||
| data: s.data.unwrap(), |
There was a problem hiding this comment.
same with unwrap() here, though I don't know the likelihood these things failing without further context
kylehh
pushed a commit
to kylehh/dynamo
that referenced
this pull request
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
Where should the reviewer start?
Test plan:
Caveats:
Background
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)