-
Notifications
You must be signed in to change notification settings - Fork 676
fix: SGLang component names to match worker registration patterns #3108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Gavin.Zhu <[email protected]>
|
👋 Hi GavinZhu-GMI! Thank you for contributing to ai-dynamo/dynamo. Just a reminder: The 🚀 |
WalkthroughUpdated two string attributes in SGLangComponentName within components/planner/src/dynamo/planner/defaults.py: prefill_worker_component_name set to "prefill" (was "worker") and decode_worker_component_name set to "backend" (was "decode".) No other fields were changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related issues
Poem
Pre-merge checks✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Nice catch! |
|
/ok to test 0c126ff |
Overview:
SGLang planner cannot detect SGLang workers due to component name mismatch, preventing autoscaling functionality.
Details:
The SGLang planner expects workers at:
instances/dynamo/worker/generateinstances/dynamo/decode/generateBut SGLang workers actually register at:
instances/dynamo/backend/generateinstances/dynamo/prefill/generateWhere should the reviewer start?
components/planner/src/dynamo/planner/defaults.py
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit