Skip to content

Conversation

@GavinZhu-GMI
Copy link
Contributor

@GavinZhu-GMI GavinZhu-GMI commented Sep 18, 2025

Overview:

SGLang planner cannot detect SGLang workers due to component name mismatch, preventing autoscaling functionality.

Details:

The SGLang planner expects workers at:

  • Prefill: instances/dynamo/worker/generate
  • Decode: instances/dynamo/decode/generate

But SGLang workers actually register at:

  • Default: instances/dynamo/backend/generate
  • Prefill mode: instances/dynamo/prefill/generate

Where should the reviewer start?

components/planner/src/dynamo/planner/defaults.py

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

Summary by CodeRabbit

  • Refactor
    • Standardized component names: the prefill worker is now labeled “prefill,” and the decode worker is now labeled “backend.”
    • Improves consistency across services for clearer identification in dashboards, logs, and configurations.
    • If you reference the old labels in custom configs, monitors, or scripts, update them to the new names.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 18, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions
Copy link

👋 Hi GavinZhu-GMI! Thank you for contributing to ai-dynamo/dynamo.

Just a reminder: The NVIDIA Test Github Validation CI runs an essential subset of the testing framework to quickly catch errors.Your PR reviewers may elect to test the changes comprehensively before approving your changes.

🚀

@github-actions github-actions bot added the external-contribution Pull request is from an external contributor label Sep 18, 2025
@GavinZhu-GMI GavinZhu-GMI changed the title Fix SGLang component names to match worker registration patterns fix: SGLang component names to match worker registration patterns Sep 18, 2025
@github-actions github-actions bot added the fix label Sep 18, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 18, 2025

Walkthrough

Updated two string attributes in SGLangComponentName within components/planner/src/dynamo/planner/defaults.py: prefill_worker_component_name set to "prefill" (was "worker") and decode_worker_component_name set to "backend" (was "decode".) No other fields were changed.

Changes

Cohort / File(s) Summary of Changes
Planner defaults adjustments
components/planner/src/dynamo/planner/defaults.py
Updated SGLangComponentName: prefill_worker_component_name "worker" → "prefill"; decode_worker_component_name "decode" → "backend". No other attribute changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

Poem

I twitch my whiskers, tiny QA knight,
Renamed two strings, set labels right.
From worker to prefill, backend in tow,
Pipelines hop smoother wherever they go.
Carrot commit sealed, tests in the light—
Thump-thump, the planner’s ready for flight! 🥕🐇

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed The PR description follows the repository template and includes the required sections: Overview, Details, Where should the reviewer start, and Related Issues with "closes GitHub issue: #3106". The Details clearly explain the component-name mismatch, list the expected vs actual registration names, and point reviewers to components/planner/src/dynamo/planner/defaults.py. It would be slightly stronger with a brief note about tests or rollout impact, but it is otherwise complete and actionable.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Title Check ✅ Passed The title succinctly and accurately describes the primary change: updating SGLang component names to match worker registration patterns. It is concise, specific to the subsystem, and avoids extraneous details or vague wording. This directly reflects the PR objectives and the changes in components/planner/src/dynamo/planner/defaults.py that align planner defaults with worker registration names.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@PeaBrane
Copy link
Contributor

Nice catch!

@PeaBrane
Copy link
Contributor

/ok to test 0c126ff

@PeaBrane PeaBrane merged commit 5915a69 into ai-dynamo:main Sep 19, 2025
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external-contribution Pull request is from an external contributor fix size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants