Repository navigation
Conversation
This was referenced Nov 3, 2026
nnshah1
force-pushed
the
nnshah1/gr-core-a2-lif-core
branch
from
November 3, 2026 23:49
a97c545 to
bdf7f37
Compare
nnshah1
force-pushed
the
nnshah1/gr-core-a3-lif-locality
branch
from
November 3, 2026 23:49
6b43bb1 to
25a5025
Compare
Contributor
✅ Dynamo PR CI passed — run 41869914796 (attempt 1) on
|
nnshah1
force-pushed
the
nnshah1/gr-core-a3-lif-locality
branch
from
November 4, 2026 01:29
25a5025 to
e81d6f4
Compare
nnshah1
force-pushed
the
nnshah1/gr-core-a2-lif-core
branch
from
November 4, 2026 01:29
bdf7f37 to
33e7083
Compare
Least-in-flight ignored regions and each pool's capacity, so a request could leave its region for a pool with one fewer request in flight. It now uses affinity's placement rule on both paths: nearest region first, then the lower load (requests in flight over the pool's capacity, from its Relay), and it leaves the nearest pool only for one with more than --headroom-factor times its spare room. The rule moves to placement.rs, shared by affinity and both least-in-flight implementations, and --router-policy least-in-flight now needs --region. This intentionally changes the current least-in-flight selector. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: nnshah1 <neelays@nvidia.com>
nnshah1
force-pushed
the
nnshah1/gr-core-a3-lif-locality
branch
from
November 4, 2026 16:41
e81d6f4 to
e3374fb
Compare
nnshah1
force-pushed
the
nnshah1/gr-core-a2-lif-core
branch
from
November 4, 2026 16:41
33e7083 to
d645229
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR intentionally changes the current least-in-flight selector. Today least-in-flight ignores regions and each pool's capacity, so a request can leave its region for a pool that has just one fewer request in flight. Least-in-flight now places pools by affinity's rule on both paths (the current selector and the router core plugin):
--headroom-factortimes its spare room.Builds on #17989; the diff shows only this PR.
Key Changes
placement.rs: the placement rule (order,leading_ties,headroom,distance) is now in one place.AffinitySelector,LeastInFlightSelectorand the core'sLeastInFlightPickerall use it. Affinity's behavior does not change.LeastInFlightSelector::new(in_flight, signals, region, headroom_factor): uses the rule above. A pool with no capacity report counts as full, so without--pool-relayrequests stay on the nearest pools, fewest in flight first.PoolSignals::capacity: requests the pool's workers can run at once, from the freshest Relay report.SelectionCorePolicy::LeastInFlight(LeastInFlightConfig { signals, region, headroom_factor }). The directory now also records each pool's region.--router-policy least-in-flightnow needs--region, and it follows the Relays (--pool-relay) as affinity does.Validation
cargo test --release -p dynamo-global-router -p dynamo-global-frontend -p dynamo-global-common: all pass (common 10, router 29, frontend lib 12 + main 4 + forwarding 14).--regionfor least-in-flight.cargo fmt --checkandcargo clippy --release --all-targets -- -D warningsare clean.Issues and Ongoing Work
--router-policy least-in-flightwithout--regionnow fail to start. Without--pool-relay, no pool's capacity is known, so the rule falls back to "nearest region, then fewest in flight".Pull Request Checklist
/pr-checklistskill.🤖 Generated with Claude Code