[JulienDarve]

Summary

dynamo-sglang-sidecar does not compile on main, because GenerateRequest sets image_data, video_data and audio_data twice in lib/sidecar/sglang/src/protocol.rs.

• chore(sglang): bump SGLang to 0.5.23 #17653 (SGLang 0.5.23, merged 12:52 PM PST on 2026-11-03) added these proto fields and set them to empty.
• feat(sidecar): forward image, video, and audio inputs to SGLang #16203 (forward image, video and audio to SGLang, merged two minutes later) set the same fields to the forwarded media.

The two edits sit on different lines, so git merged them without a conflict, but Rust rejects a struct literal that names a field twice. This PR removes #17653's three empty placeholders and keeps #16203's forwarded media.

Validation

• On this head (28cbd63, main at b0a6bd1 plus this change): cargo check --tests passes for backend-common, the four sidecars, sidecar-common and the testkit. cargo test -p dynamo-sglang-sidecar --lib passed 128 of 128. Without this change, dynamo-sglang-sidecar fails to compile.
• The same change on top of main plus the engine-loss PRs (feat(backend-common): drain and exit the worker when its engine is lost #17727, feat(sidecar): restart the vLLM sidecar when vLLM stops serving #17728, feat(sidecar): restart the SGLang sidecar when SGLang stops serving #17972, feat(sidecar): restart the TensorRT-LLM sidecar when TensorRT-LLM stops serving #17973) passed the sidecar testkit suites locally.

Related Issues

• Fixes the build break from feat(sidecar): forward image, video, and audio inputs to SGLang #16203 and chore(sglang): bump SGLang to 0.5.23 #17653

Generated with Claude Code

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

build_generate_request now populates image, video, and audio data from the processed request. Media extraction rejects unsupported types and sources, and rejects media I/O options when media is present.

Changes

SGLang media request construction

Layer / File(s)	Summary
Populate generation request media lib/sidecar/sglang/src/protocol.rs	build_generate_request passes collected image, video, and audio data into the request. Extraction rejects unsupported media types and sources, and media I/O options when media is present.

Estimated code review effort: 2 (Simple) | ~5 minutes

Merge Risk: Minimal · up to 28cbd

No specific issue blocking merge is established by the supplied evidence; complete the normal build and test checks before merging.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title "fix(sidecar): set the SGLang media fields once" names the main change. The PR removes the duplicate empty image_data, video_data, and audio_data placeholders from GenerateRequest in lib/sid…
Description check		The description covers the overview (a compile break on main caused by duplicate struct field assignments from two merged PRs), the key change (removing the three empty placeholders and keeping the fo…
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title "fix(sidecar): set the SGLang media fields once" names the main change. The PR removes the duplicate empty image_data, video_data, and audio_data placeholders from GenerateRequest in lib/sidecar/sglang/src/protocol.rs, so the struct sets each media field once and the crate compiles. The title is specific, short, and in the repository's conventional-commit style.

Full details: Description check

Explanation

The description covers the overview (a compile break on main caused by duplicate struct field assignments from two merged PRs), the key change (removing the three empty placeholders and keeping the forwarded media), and validation (cargo check results and testkit runs). It also has a Related Issues section. It does not follow the template headings exactly: it uses Summary, Validation, and Related Issues rather than Overview, Key Changes, Validation, and Issues and Ongoing Work. It also lacks the Closes #XXXX issue link and the Pull Request Checklist item (I used Dynamo's /pr-checklist skill). The content is substantive, so the check passes, but the author should align the headings and add the missing checklist and issue-link items.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

CodeRabbit Verify

• Run CodeRabbit Verify to test the changes in this pull request.

Recent review info

Run configuration

• Source mode: Auto
• Repository: ai-dynamo/dynamo
• Branch: main
• File: .coderabbit.yaml
• Commit: b0a6bd1
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Enterprise
• Run ID: be3925f3-c598-4684-bf11-f39834972a6b

Commits

Reviewing files that changed from the base of the PR and between b0a6bd1 and 28cbd63.

Files selected for processing: 1

• lib/sidecar/sglang/src/protocol.rs

Files with no reviewable changes: 1

• lib/sidecar/sglang/src/protocol.rs

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

[KrishnanPrash]

Thank you for the fixes!