Repository navigation
feat(trtllm): support audio through the OpenEngine sidecar - #16871
Merged
Merged
Conversation
Signed-off-by: krishung5 <krish@nvidia.com>
Signed-off-by: krishung5 <krish@nvidia.com>
Signed-off-by: krishung5 <krish@nvidia.com>
Signed-off-by: krishung5 <krish@nvidia.com>
Signed-off-by: krishung5 <krish@nvidia.com>
Signed-off-by: krishung5 <krish@nvidia.com>
Signed-off-by: krishung5 <krish@nvidia.com>
Signed-off-by: krishung5 <krish@nvidia.com>
Signed-off-by: krishung5 <krish@nvidia.com>
Signed-off-by: krishung5 <krish@nvidia.com>
Signed-off-by: krishung5 <krish@nvidia.com>
Signed-off-by: krishung5 <krish@nvidia.com>
Signed-off-by: krishung5 <krish@nvidia.com>
Signed-off-by: krishung5 <krish@nvidia.com>
Signed-off-by: krishung5 <krish@nvidia.com>
Signed-off-by: krishung5 <krish@nvidia.com>
Signed-off-by: krishung5 <krish@nvidia.com>
Signed-off-by: krishung5 <krish@nvidia.com>
Signed-off-by: krishung5 <krish@nvidia.com>
…dia-dynamo # Conflicts: # .github/workflows/pr.yaml # lib/sidecar/trtllm/src/tests/disagg.rs
…nto openengine-image-media-dynamo Signed-off-by: krishung5 <krish@nvidia.com> # Conflicts: # .github/scripts/test-filters.js # .github/workflows/pr.yaml # lib/sidecar/trtllm/src/tests/disagg.rs # lib/sidecar/trtllm/src/tests/e2e.rs
Signed-off-by: krishung5 <krish@nvidia.com>
…dia-dynamo # Conflicts: # .github/workflows/pr.yaml
…dia-dynamo Signed-off-by: krishung5 <krish@nvidia.com>
1 task done
Signed-off-by: krishung5 <krish@nvidia.com>
1 task done
tanmayv25
approved these changes
Nov 3, 2026
KrishnanPrash
approved these changes
Nov 3, 2026
nv-tusharma
approved these changes
Nov 3, 2026
…a-dynamo Signed-off-by: krishung5 <krish@nvidia.com> # Conflicts: # .github/workflows/shared-test-trtllm-nightly-image.yml # lib/sidecar/testkit/tests/support/trtllm.rs # lib/sidecar/testkit/tests/trtllm_multimodal.rs # lib/sidecar/trtllm/README.md # lib/sidecar/trtllm/ci/run_image_test.py # lib/sidecar/trtllm/ci/tests/test_run_media_test.py # lib/sidecar/trtllm/src/client.rs # lib/sidecar/trtllm/src/convert.rs # lib/sidecar/trtllm/src/convert/request_tests.rs # lib/sidecar/trtllm/src/test_fixtures.rs # lib/sidecar/trtllm/src/tests/e2e.rs
krishung5
enabled stacked auto-merge (squash)
November 3, 2026 22:41
1 task done
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add audio URL/data-URI passthrough to the TensorRT-LLM sidecar, stacked on the updated video wiring PR #16870. The image foundation #16613 is merged, and both branches include current main (
3057891245). Support is gated by the loaded engine's advertised media and input capabilities. Text-only processors such as Whisper receive the complete formatted prompt, preserving language/task prefixes and empty default prompts.Key Changes
116 added production lines relative to the video branch (excluding tests, CI, comments, and blank lines).
DYN_MM_ALLOW_REMOTE_URLSrejects image, video, and audio HTTP(S) sources before engine dispatch while inline data URIs remain supported.Validation
Merged the video branch's terminal-usage fix: hold a trailing hidden EOS until terminal engine usage arrives, then remove the confirmed hidden stop. This prevents the frontend from ending the stream before receiving authoritative prompt/cached-prompt usage.
The local GPU run used the unmodified official
nvcr.io/nvidia/tensorrt-llm/release:1.4.0rc3.dev202610300406image (sourceac6fb72d9fa1caf2b2d730aa4797727e6b3f6d23), on one RTX 5880 Ada GPU with one aggregated worker. An isolated container used matching userspace driver libraries to work around the host library mismatch; host configuration was unchanged. No live disaggregated or multiworker routing validation is claimed here.Completion accounting follows the shared frontend's delivered-token convention: Whisper reports 16 engine tokens including hidden EOS; HTTP reports 15 after that EOS is removed, and total 19 (=4+15). Checks explicitly verify the removed EOS and prompt/completion/total consistency.
The official-nightly audio GPU job passed at the prior published audio head
3b11847574. The new fix has local GPU validation; CI for the new head is separate.Issues and Ongoing Work
refs DIS-2971. Stacked on #16870. Upstream audio support (NVIDIA/TensorRT-LLM#20655) is merged. An official nightly confirmed to contain audio support is
1.4.0rc3.dev202610300406, sourceac6fb72d9fa1caf2b2d730aa4797727e6b3f6d23; its ancestry and handler table include audio support. The resolver selects the latest published regular nightly automatically. The audio GPU lane passed in the linked official-nightly run.The GPU lane covers the Rust sidecar adapter through native OpenEngine and real inference. Full Dynamo frontend HTTP CI remains in the shared-runtime follow-up, pending its runtime upgrade; local full-path GPU validation is recorded above.
Pull Request Checklist
/pr-checklistskill for the review fixes and CI update.Summary by CodeRabbit
New Features
audio_urland mapped to the audio modality.Bug Fixes