Repository navigation
Conversation
Signed-off-by: bzsuni <bingzhe.sun@daocloud.io>
|
👋 Hi bzsuni! Thank you for contributing to ai-dynamo/dynamo. Just a reminder: The 🚀 |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: ai-dynamo/dynamo/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe asymmetric image-feature validation test now accepts ChangesImage-feature validation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This updates a single validation test to accept vLLM 0.30's earlier rejection of mismatched multimodal keys. It has no production behavior impact and is low risk to merge. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Comment |
|
/ok to test 3b13f58 |
|
Thanks for the contribution! #15380 just merged for the same fix, so we are closing it as duplicate. |
Overview:
Update the TITO asymmetric-feature validation tests for vLLM 0.30
Related PRs: #15179 #15182
vLLM 0.30 rejects mismatched multimodal keys during
GenerateRequestvalidation, before reaching Dynamo's image-feature validation. These inputs
therefore raise a Pydantic
ValidationErrorinstead of Dynamo'sTypeErrorDetails:
Allow either validation path while still matching the specific rejection
messages. The same malformed inputs must still be rejected
No production behavior changes.
Observed in nightly CI
Where should the reviewer start?
test_tito_adapter_rejects_asymmetric_image_feature_objects()incomponents/src/dynamo/vllm/tests/test_vllm_engine_generate.pyValidation
Black, isort, and
git diff --checkpassedRelated Issues
Summary by CodeRabbit