Repository navigation
feat(vllm): add Python RL serving parity for generate endpoint - #15179
Merged
biswapanda merged 18 commits intoSep 28, 2026
Merged
Conversation
Contributor
|
👋 Hi biswapanda! Thank you for contributing to ai-dynamo/dynamo. Just a reminder: The 🚀 |
Contributor
|
/ok to test 6190cd3 |
Contributor
|
/ok to test e7b84bb |
biswapanda
force-pushed
the
feat/dynamo-vllm-rl-parity
branch
from
September 22, 2026 20:56
e7b84bb to
23061d1
Compare
Contributor
|
/ok to test 23061d1 |
Contributor
|
/ok to test 613fd66 |
biswapanda
marked this pull request as ready for review
September 22, 2026 23:09
biswapanda
enabled auto-merge (squash)
September 22, 2026 23:09
Signed-off-by: Biswa Panda <biswa.panda@gmail.com>
Signed-off-by: Biswa Panda <biswa.panda@gmail.com>
biswapanda
force-pushed
the
feat/dynamo-vllm-rl-parity
branch
from
September 24, 2026 05:24
c71affd to
404be27
Compare
Contributor
|
/ok to test 404be27 |
There was a problem hiding this comment.
Previously reported defects still present:
- Original discussion: Still present:
adapt_engine_generate_requestrejects everysampling_params.stoprequest even though vLLM supports stop strings when detokenization is enabled, andtest_tito_adapter_rejects_stop_strings_but_preserves_stop_token_idsnow codifies that unsupported rejection instead of preserving stop-string handling.
Signed-off-by: Biswa Panda <biswa.panda@gmail.com>
Contributor
|
/ok to test eee5e44 |
Signed-off-by: Biswa Panda <biswa.panda@gmail.com>
Contributor
|
/ok to test 0ecc46b |
Closed
jthomson04
approved these changes
Sep 28, 2026
Contributor
|
/ok to test f168ae1 |
Contributor
|
/ok to test d9a2532 |
1 task done
1 task done
This was referenced Sep 29, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This brings the Python
dynamo.vllmworker to parity with Dynamo's RL path for aggregated vLLM deployments. It adapts Rust-frontend token-in/token-out Generate envelopes, preserves trainer replay metadata, publishes the topology and capabilities needed by RL orchestration, and serializes standard vLLM LoRA updates with active generation.area breakdown by code owner
Validation
cargo fmt --all -- --checkcargo test -p dynamo-llm --no-default-features protocols::openai::generate::tests -- --nocapture— 32 passedtest_vllm_legacy_lora.py— 17 passed with vLLM 0.29 after the splittest_vllm_worker_handler.pyandtest_vllm_engine_generate.py— 119 passed, 5 dependency-gated skips after the split0.0004,0.0004,0.00030.0003,0.0004,0.0006; immutable adapters v0-v3 loaded and drained successfullySummary by CodeRabbit
New Features
Bug Fixes
Post-review validation
Where should the reviewer start?
components/src/dynamo/vllm/engine_generate.pyfor native Generate request adaptation.components/src/dynamo/vllm/handlers.pyandcomponents/src/dynamo/vllm/lora_state.pyfor response metadata and LoRA request draining.components/src/dynamo/common/rl/admin.pyfor RL topology publication.Related Issues