Repository navigation
Conversation
Signed-off-by: William Arnold <7565007+Aphoh@users.noreply.github.com>
Aphoh
force-pushed
the
warnold/sglang-generate-metadata-upload
branch
from
September 16, 2026 00:47
3a04474 to
3a9ecfc
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nvextobject on native SGLang/generaterequests as Dynamo-owned and remove it from the opaque request forwarded to SGLangnvextenvelope inPreprocessedRequest.extra_args, enabling the OpenDAL metadata uploader added by feat(sglang): upload sidecar metadata with OpenDAL #11470nvextwhile preservingx-data-parallel-rankheader precedence/generatemetadata-upload configuration and response behaviorStacked on #11470. Merge that PR first.
Validation
cargo +stable test -p dynamo-llm --lib sglang_generate --locked— 5 passednvextownership, unknown-field rejection, and opaque-response tests — 4 passedcargo +stable test --manifest-path lib/sidecar/sglang/Cargo.toml --locked— 43 passedPOST /generatenvextremained Dynamo-owned and was not forwarded to SGLangchoice_0.msgpack.zstfallback_urlreceived the artifactzstandardandmsgpack, verifying schema version 1 and terminal metadatacargo +stable clippy -p dynamo-llm --lib --no-deps --lockedwith allowances for pre-existing Rust 1.98 lintscargo +stable fmt --all -- --checkpython3 docs/fern/scripts/docs_lint.py --scan docs— 0 errors (pre-existing warnings remain)git diff --check