Repository navigation
fix(vllm): use engine-reported logical KV block sizes - #14590
Closed
JulienDarve wants to merge 4 commits into
Closed
JulienDarve wants to merge 4 commits into
JulienDarve wants to merge 4 commits into
Conversation
Signed-off-by: Julien Darve <jdarve@NVIDIA.com>
Signed-off-by: Julien Darve <jdarve@NVIDIA.com>
Signed-off-by: Julien Darve <jdarve@NVIDIA.com>
Signed-off-by: Julien Darve <jdarve@NVIDIA.com>
Contributor
Author
|
Being implemented in the version bump PR: #15182 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use vLLM's initialized logical block size throughout the legacy Python backend. With physical block size 16 and DCP=2, full KV events contain 32 tokens; configuring Dynamo with 16 causes those events to be rejected.
AsyncLLM.get_kv_cache_group_metadata()and cache the main-attention logical size for the publisher, base-model registration, and LoRA registration.Validation
Tests used Python source from JulienDarve/vllm#3 at
20905fbeda0eb9760e1782d6ea5a0f96d4fe2457, with existing precompiled extensions.Dependencies
Draft until the metadata API is available across supported CUDA, CPU, and XPU runtimes. The current vLLM 0.28.0 CUDA/CPU and 0.27.1 XPU pins do not provide this contract.
Related Issues