Skip to content

docs: align Kubernetes build selector with CLI - #12729

Merged
athreesh merged 3 commits into
mainfrom
docs/k8s-selector-cli-parity
Aug 5, 2026
Merged

docs: align Kubernetes build selector with CLI#12729
athreesh merged 3 commits into
mainfrom
docs/k8s-selector-cli-parity

Conversation

@athreesh

@athreesh athreesh commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Update the Kubernetes quickstart container selector to match the CLI guide support-matrix selector shape: hardware, backend, Dynamo build, version, and install form.
  • Keep Kubernetes-specific output: planner image variables for NVIDIA GPU paths and XPU image build/push commands for Intel GPU paths.
  • Rename the shared CLI selector heading from "Choose your local build" to "Choose your build".
  • Address review feedback by using the published nightly planner tag, removing the unused runtime image export, and reusing selector-provided Dynamo version values in the quickstart.

Why

The CLI guide and Kubernetes guide were using two different selector components. The CLI selector showed the support boundary by keeping unsupported combinations visible but disabled, while the Kubernetes selector used a smaller custom image-path control. This PR makes the Kubernetes quickstart visually and conceptually match the CLI selector while preserving Kubernetes-specific commands.

Related Issues

  • None.

Reviewer Start

  • Start with docs/fern/components/KubernetesContainerSelector.tsx for the selector behavior.
  • Then review docs/fern/pages/kubernetes/getting-started/quickstart.mdx for how the selected variables are consumed.

Validation

  • npx --yes fern-api@5.80.2 docs broken-links
  • npx --yes fern-api@5.80.2 check --warnings — 0 errors; existing warnings only for unauthenticated redirect check and light-mode accent contrast
  • git diff --check origin/main...HEAD
  • Local preview: http://localhost:3000/dynamo/dev/kubernetes/getting-started/quickstart

Signed-off-by: Anish Maddipoti <amaddipoti@nvidia.com>
@athreesh
athreesh requested a review from a team as a code owner August 5, 2026 23:37
@copy-pr-bot

copy-pr-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added docs documentation Improvements or additions to documentation labels Aug 5, 2026
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The Kubernetes selector now supports hardware, backend, release channel, version, and install-form selections. It filters unsupported combinations, generates backend-specific commands, and updates recommendation metadata. Install selector descriptions and headings no longer use “local” terminology.

Changes

Kubernetes installation selector

Layer / File(s) Summary
Installation data and availability
docs/fern/components/InstallSelector.tsx, docs/fern/components/KubernetesContainerSelector.tsx
Shared installation types and configuration now define backend, channel, form, runtime image, and hardware-based availability.
Backend and channel command generation
docs/fern/components/KubernetesContainerSelector.tsx
Commands now use the selected backend, channel, version, registry, and backend-specific runtime image. Stable and nightly paths are supported.
Selection state and recommendation UI
docs/fern/components/KubernetesContainerSelector.tsx
The UI now selects compatible backend, channel, version, and form options. Unsupported combinations remain visible and disabled. Recommendation metadata reflects the selected installation data.

Estimated code review effort: 4 (Complex) | ~35 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the Kubernetes selector alignment with the CLI, which is the main change.
Description check ✅ Passed The description explains the changes, rationale, review starting points, related issues, and validation steps.

Comment @coderabbitai help to get the list of available commands.

@harryskim harryskim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 4 potential issues.

Open in Devin Review

Comment thread docs/fern/components/KubernetesContainerSelector.tsx Outdated
Comment thread docs/fern/components/KubernetesContainerSelector.tsx Outdated
Comment thread docs/fern/components/KubernetesContainerSelector.tsx Outdated
Comment thread docs/fern/components/KubernetesContainerSelector.tsx
Signed-off-by: Anish Maddipoti <amaddipoti@nvidia.com>
Comment thread docs/fern/components/KubernetesContainerSelector.tsx
@athreesh
athreesh enabled auto-merge (squash) August 5, 2026 23:49
Signed-off-by: Anish Maddipoti <amaddipoti@nvidia.com>
@athreesh

athreesh commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 851cc43

@athreesh
athreesh merged commit b6d6480 into main Aug 5, 2026
98 checks passed
@athreesh
athreesh deleted the docs/k8s-selector-cli-parity branch August 5, 2026 23:56
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

hhzhang16 added a commit that referenced this pull request Aug 6, 2026
dyn-3691-extract-shared-target-pid-cuda-customstorage-operation-layer

* 'main' of https://github.com/ai-dynamo/dynamo: (65 commits)
  fix(frontend): emit SGLang stream role once (#12741)
  docs(fern): promote v1.3.1 to current release (#12752)
  fix(docs): remove duplicate unscoped community-rail CSS rules (#12615)
  feat(operator): migrate CRD storage to v1beta1 (#11904)
  fix: synchronize self-benchmark capacity across DP ranks (#12021)
  chore(deps): bump dynamo-tokenizers to 1.8.0 (#12707)
  fix(frontend): preserve split UTF-8 characters (#12688)
  docs: align Kubernetes build selector with CLI (#12729)
  fix(frontend): preserve completion backend error status (#12706)
  fix(operator): replace snapshot pods after GMS restart (#11286)
  refactor(media): rename installer module, drop --packages per review
  fix(media): harden installer against three pre-redesign review findings
  fix(media): verify installs in a fresh interpreter; teach --pip-args= form
  test(serve): install test-time decoders at the validated bounds
  feat(media): explicit installer for additional media decoders
  docs(spica): correct kv_load_ratio support guidance (#12714)
  feat(operator): add experimental grove.forceScalingGroup for single-node components (#11772)
  fix(vllm): declare entry-stage engine_input_source in GLM-Image NIXL config (#12709)
  chore: bump trtllm to v1.3.0rc23 (#12532)
  perf: remove trtllm postprocessing workers from the args as post processing workers are not effective in dynamo (#12592)
  ...

Signed-off-by: Hannah Zhang <hannahz@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs documentation Improvements or additions to documentation size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants