fix(docs): remove duplicate unscoped community-rail CSS rules - #12615
Conversation
Signed-off-by: weizhoublue <weizhou.lan@daocloud.io>
WalkthroughChangesCommunity rail CSS cleanup
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Comment |
|
@dagil-nvidia , hi |
|
/ok to test 7742369 |
dagil-nvidia
left a comment
There was a problem hiding this comment.
Verified and correct. Thank you for catching this.
The duplicates are mine: restoring the community rail in #12539 appended its rules to the end of `LANDING_CSS`, and the extraction matched rule blocks inside @media queries as well as the media blocks themselves. Every responsive override got emitted twice, once correctly wrapped and once naked. The naked copies then won on source order, so position: static; width: min(100%, 720px) beat the real rail and it dropped into normal flow as full-width cards under the hero.
Checked the result: one unscoped .dynamo-welcome__community left (position: absolute; width: 242px), with the two responsive overrides still scoped to max-width: 1360px and max-width: 640px. That is the right shape.
The indentation on the removed rules is the tell, four spaces with the brace at two, which is what a rule looks like after it has been lifted out of its @media wrapper.
dyn-3691-extract-shared-target-pid-cuda-customstorage-operation-layer * 'main' of https://github.com/ai-dynamo/dynamo: (65 commits) fix(frontend): emit SGLang stream role once (#12741) docs(fern): promote v1.3.1 to current release (#12752) fix(docs): remove duplicate unscoped community-rail CSS rules (#12615) feat(operator): migrate CRD storage to v1beta1 (#11904) fix: synchronize self-benchmark capacity across DP ranks (#12021) chore(deps): bump dynamo-tokenizers to 1.8.0 (#12707) fix(frontend): preserve split UTF-8 characters (#12688) docs: align Kubernetes build selector with CLI (#12729) fix(frontend): preserve completion backend error status (#12706) fix(operator): replace snapshot pods after GMS restart (#11286) refactor(media): rename installer module, drop --packages per review fix(media): harden installer against three pre-redesign review findings fix(media): verify installs in a fresh interpreter; teach --pip-args= form test(serve): install test-time decoders at the validated bounds feat(media): explicit installer for additional media decoders docs(spica): correct kv_load_ratio support guidance (#12714) feat(operator): add experimental grove.forceScalingGroup for single-node components (#11772) fix(vllm): declare entry-stage engine_input_source in GLM-Image NIXL config (#12709) chore: bump trtllm to v1.3.0rc23 (#12532) perf: remove trtllm postprocessing workers from the args as post processing workers are not effective in dynamo (#12592) ... Signed-off-by: Hannah Zhang <hannahz@nvidia.com>
Overview:
Details:
the mobile-only rule bodies appear twice: once unguarded at the top level, once correctly wrapped in their @media blocks. CSS cascade order lets the unguarded copy win everywhere.
In result, desktop browsers (>1360px) get the narrow-screen sidebar layout instead of the floating rail, and hover/scroll animations are disabled for all users, not just prefers-reduced-motion users.
The solution is to delete the stray unguarded duplicate, keep only the properly @media-scoped versions.
Where should the reviewer start?
Related Issues
🔗 This PR is linked to an issue:
🚫 This PR is NOT linked to an issue:
Summary by CodeRabbit