Skip to content

fix(docs): remove duplicate unscoped community-rail CSS rules - #12615

Merged
dagil-nvidia merged 1 commit into
ai-dynamo:mainfrom
weizhoublue:fix/landing-styles-duplicate-media-rules
Aug 6, 2026
Merged

fix(docs): remove duplicate unscoped community-rail CSS rules#12615
dagil-nvidia merged 1 commit into
ai-dynamo:mainfrom
weizhoublue:fix/landing-styles-duplicate-media-rules

Conversation

@weizhoublue

@weizhoublue weizhoublue commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Overview:

Details:

the mobile-only rule bodies appear twice: once unguarded at the top level, once correctly wrapped in their @media blocks. CSS cascade order lets the unguarded copy win everywhere.

// line 2002
.dynamo-welcome__community {
  position: absolute;
  top: -20rem;
  right: calc((100vw - 1200px) / -2 + 1rem);
  z-index: 30;
  display: flex;
  width: 242px;
  flex-direction: column;
  gap: 0.55rem;
}

....

// line 2141
.dynamo-welcome__community {
    position: static;
    width: min(100%, 720px);
    margin: 2rem auto 0;
    flex-direction: row;
  }
....  
  

In result, desktop browsers (>1360px) get the narrow-screen sidebar layout instead of the floating rail, and hover/scroll animations are disabled for all users, not just prefers-reduced-motion users.

The solution is to delete the stray unguarded duplicate, keep only the properly @media-scoped versions.

Where should the reviewer start?

Related Issues

⚠️ This section is required. Choose one path below and delete the other.

🔗 This PR is linked to an issue:

  • Closes #XXXX

🚫 This PR is NOT linked to an issue:

  • Confirmed — no related issue

Open in Devin Review

Summary by CodeRabbit

  • Style
    • Removed duplicate responsive and reduced-motion styling for the community notification rail.
    • Preserved its responsive layout and transition behavior.

Signed-off-by: weizhoublue <weizhou.lan@daocloud.io>
@weizhoublue
weizhoublue requested a review from a team as a code owner August 4, 2026 00:39
@copy-pr-bot

copy-pr-bot Bot commented Aug 4, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@weizhoublue
weizhoublue temporarily deployed to external_collaborator August 4, 2026 00:39 — with GitHub Actions Inactive
@weizhoublue
weizhoublue temporarily deployed to external_collaborator August 4, 2026 00:39 — with GitHub Actions Inactive
@github-actions github-actions Bot added fix documentation Improvements or additions to documentation labels Aug 4, 2026
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot added the external-contribution Pull request is from an external contributor label Aug 4, 2026
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Changes

Community rail CSS cleanup

Layer / File(s) Summary
Remove duplicate community rail rules
docs/fern/components/LandingStyles.tsx
Removed duplicate community rail sizing, layout, and reduced-motion transition rules. The later responsive media queries remain.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the bug and fix, but required sections remain incomplete, including reviewer guidance and the related-issue selection. Complete the Overview and reviewer-start sections, and select either the linked issue or no-related-issue option instead of leaving placeholders.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the removal of duplicate unscoped community-rail CSS rules.

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@weizhoublue

Copy link
Copy Markdown
Contributor Author

@dagil-nvidia , hi
Please help review whether this PR makes sense, thanks

@rmccorm4

rmccorm4 commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

/ok to test 7742369

@dagil-nvidia dagil-nvidia left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified and correct. Thank you for catching this.

The duplicates are mine: restoring the community rail in #12539 appended its rules to the end of `LANDING_CSS`, and the extraction matched rule blocks inside @media queries as well as the media blocks themselves. Every responsive override got emitted twice, once correctly wrapped and once naked. The naked copies then won on source order, so position: static; width: min(100%, 720px) beat the real rail and it dropped into normal flow as full-width cards under the hero.

Checked the result: one unscoped .dynamo-welcome__community left (position: absolute; width: 242px), with the two responsive overrides still scoped to max-width: 1360px and max-width: 640px. That is the right shape.

The indentation on the removed rules is the tell, four spaces with the brace at two, which is what a rule looks like after it has been lifted out of its @media wrapper.

@dagil-nvidia
dagil-nvidia merged commit 06045a2 into ai-dynamo:main Aug 6, 2026
93 checks passed
hhzhang16 added a commit that referenced this pull request Aug 6, 2026
dyn-3691-extract-shared-target-pid-cuda-customstorage-operation-layer

* 'main' of https://github.com/ai-dynamo/dynamo: (65 commits)
  fix(frontend): emit SGLang stream role once (#12741)
  docs(fern): promote v1.3.1 to current release (#12752)
  fix(docs): remove duplicate unscoped community-rail CSS rules (#12615)
  feat(operator): migrate CRD storage to v1beta1 (#11904)
  fix: synchronize self-benchmark capacity across DP ranks (#12021)
  chore(deps): bump dynamo-tokenizers to 1.8.0 (#12707)
  fix(frontend): preserve split UTF-8 characters (#12688)
  docs: align Kubernetes build selector with CLI (#12729)
  fix(frontend): preserve completion backend error status (#12706)
  fix(operator): replace snapshot pods after GMS restart (#11286)
  refactor(media): rename installer module, drop --packages per review
  fix(media): harden installer against three pre-redesign review findings
  fix(media): verify installs in a fresh interpreter; teach --pip-args= form
  test(serve): install test-time decoders at the validated bounds
  feat(media): explicit installer for additional media decoders
  docs(spica): correct kv_load_ratio support guidance (#12714)
  feat(operator): add experimental grove.forceScalingGroup for single-node components (#11772)
  fix(vllm): declare entry-stage engine_input_source in GLM-Image NIXL config (#12709)
  chore: bump trtllm to v1.3.0rc23 (#12532)
  perf: remove trtllm postprocessing workers from the args as post processing workers are not effective in dynamo (#12592)
  ...

Signed-off-by: Hannah Zhang <hannahz@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation external-contribution Pull request is from an external contributor fix size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants