Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion deploy/helm/charts/power-agent/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,10 @@ type: application
# COPY now includes it, and the dev-pod script ConfigMap MUST add a
# `managed_state.py` key. Minor bump per SemVer (additive module; dev-pod
# users must extend their ConfigMap, see templates/dev-pod.yaml header).
version: 1.3.0
# 1.3.1: fix whitespace-trim that glued apiVersion onto the SPDX comment and
# blocked default helm install. Patch bump; appVersion unchanged (image code
# unchanged).
version: 1.3.1
# appVersion tracks the agent image's runtime code. It stayed 1.1.0 across
# chart 1.2.0 because that bump was values-only (image.digest field, no image
# code change). Chart 1.3.0 adds managed_state.py to the image COPY, so the
Expand Down
2 changes: 1 addition & 1 deletion deploy/helm/charts/power-agent/templates/daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
# SPDX-License-Identifier: Apache-2.0

{{- if .Values.daemonset.enabled }}
{{- include "power-agent.validateTerminationGracePeriod" . -}}
{{- include "power-agent.validateTerminationGracePeriod" . }}
Comment thread
kaim-eng marked this conversation as resolved.
apiVersion: apps/v1
kind: DaemonSet
metadata:
Expand Down
2 changes: 1 addition & 1 deletion deploy/helm/charts/power-agent/templates/dev-pod.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
# 'managed_state'`.

{{- if .Values.dev.enabled }}
{{- include "power-agent.validateTerminationGracePeriod" . -}}
{{- include "power-agent.validateTerminationGracePeriod" . }}
apiVersion: v1
kind: Pod
metadata:
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
# SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0

# Regression: right-trim (`-}}`) on silent validateTerminationGracePeriod
# include ate the newline before `apiVersion`, gluing it onto the SPDX
# comment:
#
# # SPDX-License-Identifier: Apache-2.0apiVersion: apps/v1
#
# helm template / helm lint both exit 0 on that broken render; only
# install/apply fails with "apiVersion not set". The existing suite
# (including grace_period_test.yaml) also stayed green because nothing
# asserted apiVersion / isAPIVersion. This suite is the gate that
# would have caught it.

suite: apiVersion survives whitespace-trim around grace validation
release:
name: power-agent
namespace: dynamo-system

tests:
- it: DaemonSet default path keeps apiVersion as a document key
templates:
- templates/daemonset.yaml
set:
image.tag: v1.4.0
asserts:
- isKind:
of: DaemonSet
- isAPIVersion:
of: apps/v1
- equal:
path: apiVersion
value: apps/v1

- it: dev pod path keeps apiVersion as a document key
templates:
- templates/dev-pod.yaml
set:
daemonset.enabled: false
dev.enabled: true
dev.nodeName: gpu-node-0
asserts:
- isKind:
of: Pod
- isAPIVersion:
of: v1
- equal:
path: apiVersion
value: v1
Loading