fix(power-agent): cherry-pick keep apiVersion off SPDX comment (#12651) - #12652
Conversation
github-actions
Bot
added
fix
deployment::k8s
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| # Regression for DYN-3741 / NVBug 6555989: a right-trim (`-}}`) on the | ||
| # silent validateTerminationGracePeriod include ate the newline before | ||
| # `apiVersion`, gluing it onto the SPDX comment: |
There was a problem hiding this comment.
🟡 Internal ticket reference included in a shipped test file
An internal-only tracker ID is written into the new chart test file's comment (DYN-3741 at deploy/helm/charts/power-agent/tests/api_version_whitespace_test.yaml:4), which the repository rules forbid in source that ships to main because outside readers cannot resolve it.
Impact: External contributors see a reference they cannot look up, and the repo's ticket-reference policy is violated.
Rule source: .ai/linear-ticket-refs.md via .coderabbit.yaml path instructions
.coderabbit.yaml instructs flagging any <PROJECT>-NNNN Linear ID in added lines of *.yaml files, and .ai/linear-ticket-refs.md says source in the working tree must not carry DYN-XXXX references; they should be replaced with a public GitHub issue number (GH-NNNN / #NNNN). Only *.md docs are exempt. The added comment block also cites the internal NVBug number.
| # Regression for DYN-3741 / NVBug 6555989: a right-trim (`-}}`) on the | |
| # silent validateTerminationGracePeriod include ate the newline before | |
| # `apiVersion`, gluing it onto the SPDX comment: | |
| # Regression for GitHub issue #12651: a right-trim (`-}}`) on the | |
| # silent validateTerminationGracePeriod include ate the newline before | |
| # `apiVersion`, gluing it onto the SPDX comment: |
Was this helpful? React with 👍 or 👎 to provide feedback.
|
/ok to test 0383183 |
![dynamo-review-agent[bot]](https://avatars.githubusercontent.com/u/201626793?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
Drop the trailing whitespace-trim on the silent validateTerminationGracePeriod include so helm does not glue apiVersion onto the SPDX comment (DYN-3741 / NVBug 6555989). Add isAPIVersion helm-unittest coverage; template/lint stay green on the broken render and the old suite did not catch it. Signed-off-by: Kai Ma <kaim@nvidia.com> (cherry picked from commit 4bb3761)
Rewrite the regression-test comment without Linear/NVBug IDs and bump the chart patch version so the install-blocking apiVersion fix is a distinct chart artifact on main and release/1.4.0. Signed-off-by: Kai Ma <kaim@nvidia.com> (cherry picked from commit cafb4f5)
0383183 to
8f4cf2f
Compare
|
/ok to test 8f4cf2f |
2 participants
Summary
Cherry-pick of both commits from #12651 onto
release/1.4.0:4bb3761f85— fix the whitespace trim and add the regression suitecafb4f55e6— remove internal ticket references and bump chart version to 1.3.1Clears P1 NVBug 6555989 / DYN-3741: the power-agent chart's default DaemonSet path cannot be installed after selecting the required image because a whitespace-trim action glues
apiVersiononto the SPDX comment. The same issue affects the opt-in dev-pod path.Both commits were cherry-picked with
-x. Their stable patch IDs match the source commits, and the finaldeploy/helm/charts/power-agent/subtree is identical to the #12651 source-branch tip. Actual diff: 4 files, +56/-3.Main PR
#12651
Validation
-xcafb4f55e6make -C deploy/helm/charts/power-agent lint testpasses in release-branch CI: 5 suites, 50 testsPRworkflow and its status gates passThe separate
lycheedocs-link check is red on two 404 links in untoucheddocs/fern/features/diffusion/text-to-text/README.md; this PR changes no documentation.Related