Skip to content

fix(ci): remove Grove mutation assertion #12399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dagil-nvidia merged 1 commit into from
Jul 29, 2026
Merged

fix(ci): remove Grove mutation assertion #12399

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions .github/actions/setup-dynamo-operator/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -739,17 +739,6 @@ runs:
fi
}

verify_grove_admission() {
run_webhook_smoke_test 'Grove PodCliqueSet' smoke_grove
if ! jq -e '.spec.template.headlessServiceConfig != null' \
<<<"${SMOKE_OUTPUT}" >/dev/null; then
echo "::error::Grove PodCliqueSet request succeeded without the defaulting webhook mutation"
printf '%s\n' "${SMOKE_OUTPUT}" >&2
return 1
fi
echo "Grove PodCliqueSet admission succeeded with the expected defaulting mutation"
}

verify_dynamo_admission v1alpha1 smoke_v1alpha1
verify_dynamo_admission v1beta1 smoke_v1beta1
verify_grove_webhook_configuration \
Expand All @@ -760,7 +749,7 @@ runs:
validatingwebhookconfiguration \
podcliqueset-validating-webhook \
pcs.validating.webhooks.grove.io
verify_grove_admission
run_webhook_smoke_test 'Grove PodCliqueSet' smoke_grove
echo "Grove PodCliqueSet defaulting and validation webhooks are installed and healthy"
echo "::endgroup::"

Expand Down
Loading