Skip to content

ci(deploy): use runtime-versioned image tags - #12359

Closed
sttts wants to merge 43 commits into
tmonty12/dyn-940-runtime-versionfrom
sttts-ci-runtime-version-tags
Closed

ci(deploy): use runtime-versioned image tags#12359
sttts wants to merge 43 commits into
tmonty12/dyn-940-runtime-versionfrom
sttts-ci-runtime-version-tags

Conversation

@sttts

@sttts sttts commented Jul 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • tag CI deployment images as <dynamo-version>-ci-<sha>-<image> when copying them to ACR
  • keep the immutable SHA tag as the ECR build artifact
  • pass the resulting ACR tag through deploy, checkpoint, and GAIE workflows
  • remove test-side runtimeVersionOverride injection and version parsing

Dependency

Prefactor: #12362 introduces the reusable CI image-tagging changes against main. This stacked PR currently carries those workflow changes for end-to-end validation. After #12362 merges, this PR will be rebased onto it and retain only the #10494-specific test cleanup.

Why

#10494 validates runtime compatibility from the main container image tag. CI currently replaces those images with SHA-tagged artifacts, forcing generic test utilities to add an override. Giving the CI artifacts an accurate SemVer-compatible tag lets admission use the normal production path.

Validation

  • pre-commit hooks
  • git diff --check

Stacked on #10494.

@github-actions github-actions Bot added ci Issues/PRs that reference CI build/test actions labels Jul 29, 2026
@datadog-official

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot added the deployment::k8s Relates to dynamo deployment in kubernetes label Jul 29, 2026
@sttts
sttts force-pushed the sttts-ci-runtime-version-tags branch from 6d02f59 to 720205e Compare July 29, 2026 16:07
tmonty12 added 24 commits July 29, 2026 18:19
@tmonty12 @sttts
feat(operator): add runtime version override
4d138b3 
Signed-off-by: Thomas Montfort <tjmontfort12@gmail.com>
@tmonty12 @sttts
fix(operator): require DGD main images
ec03a23
@tmonty12 @sttts
refactor(operator): rely on runtime override schema validation
d739745
@tmonty12 @sttts
test(operator): cover required DCD main image
af46730
@tmonty12 @sttts
test(operator): cover required DGD main images
3bfb291
@tmonty12 @sttts
test(operator): assert missing main image path
a4e7d68
@tmonty12 @sttts
update tests
2056f8c
@tmonty12 @sttts
properly use test helpers
f56854c
@tmonty12 @sttts
remove unneeded test helpers
82852c5
@tmonty12 @sttts
cleanup
d67b87a
@tmonty12 @sttts
docs(operator): document runtime version override upgrade
4b1413c
@tmonty12 @sttts
docs(operator): clarify runtime version admission upgrade
b69caff
@tmonty12 @sttts
fix(operator): avoid runtime override rollouts
bd68b42
@tmonty12 @sttts
fix(operator): preserve source validation paths
b5aae33 
Signed-off-by: Thomas Montfort <tjmontfort12@gmail.com>
@tmonty12 @sttts
docs(operator): clarify runtime version override
9a6ec92 
Signed-off-by: Thomas Montfort <tjmontfort12@gmail.com>
@tmonty12 @sttts
fix(operator): regenerate API reference
814151b
@tmonty12 @sttts
fix(ci): update operator smoke manifests
0a9ed35
@tmonty12 @sttts
fix(test): set runtime version for CI images
75270a8
@tmonty12 @sttts
fix(operator): reuse main container lookup
d2fd3ea 
Signed-off-by: Thomas Montfort <tjmontfort12@gmail.com>
@tmonty12 @sttts
refactor(operator): reuse sidecar container lookup
b6e1219 
Signed-off-by: Thomas Montfort <tjmontfort12@gmail.com>
@tmonty12 @sttts
test(deploy): derive runtime compatibility version
8a54f9d 
Signed-off-by: Thomas Montfort <tjmontfort12@gmail.com>
@tmonty12 @sttts
feat(operator): require component pod template
64e5742 
Signed-off-by: Thomas Montfort <tjmontfort12@gmail.com>
@tmonty12 @sttts
fix(operator): propagate DGDR runtime versions
e5572f7 
Signed-off-by: Thomas Montfort <tjmontfort12@gmail.com>
@tmonty12 @sttts
fix(operator): require DGDR override on update
3f29d8a 
Signed-off-by: Thomas Montfort <tjmontfort12@gmail.com>
tmonty12 and others added 18 commits July 29, 2026 18:19
@tmonty12 @sttts
docs: clarify DGDR profiler image compatibility
e03c5cd 
Signed-off-by: Thomas Montfort <tjmontfort12@gmail.com>
@tmonty12 @sttts
fix(operator): repair runtime version CI fixtures
d79841d 
Signed-off-by: Thomas Montfort <tjmontfort12@gmail.com>
@tmonty12 @sttts
docs(helm): regenerate platform README
badbedb 
Signed-off-by: Thomas Montfort <tjmontfort12@gmail.com>
@sttts
fix(operator): preserve runtime versions across updates (#12195)
1a88aa5 
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@sttts
operator/dgdr: trust admission for spec repairs
525d667 
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@sttts
fixup! fix(operator): propagate DGDR runtime versions
7c024f9 
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@sttts
fixup! feat(operator): require component pod template
337be14 
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@sttts
fixup! operator/dgdr: trust admission for spec repairs
89891d3 
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@sttts
fixup! fixup! feat(operator): require component pod template
ed616b1 
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@sttts
fixup! fix(operator): propagate DGDR runtime versions
cfbce52 
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@sttts
fixup! fixup! fix(operator): propagate DGDR runtime versions
eff077a 
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@sttts
fixup! fixup! feat(operator): require component pod template
2e579d4 
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@sttts
fixup! fixup! fix(operator): propagate DGDR runtime versions
141be8d 
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@sttts
fixup! fixup! feat(operator): require component pod template
707edde 
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@sttts
fixup! fix(operator): repair runtime version CI fixtures
6872450 
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@sttts
fixup! fix(operator): repair runtime version CI fixtures
7b808f1 
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@sttts
operator/dgdr: defer runtime override until DGD creation
7eca3fe 
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@sttts
test/operator: use semver tags in controller fixtures
c1c2e19 
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@sttts
sttts force-pushed the tmonty12/dyn-940-runtime-version branch from 6c603f8 to c1c2e19 Compare July 29, 2026 16:21
@sttts
ci/deploy: use runtime-versioned image tags
0ac59bb 
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@sttts
sttts force-pushed the sttts-ci-runtime-version-tags branch from 720205e to 0ac59bb Compare July 29, 2026 16:22
@sttts
sttts force-pushed the tmonty12/dyn-940-runtime-version branch from c1c2e19 to 23f0120 Compare July 29, 2026 18:36
@sttts

sttts commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

Closing this follow-up because its final changes are now folded directly into #10494 after rebasing #10494 onto the prefactor in #12362. The workflow portion is provided by #12362, and the remaining test-helper cleanup is already present on current main.

@sttts sttts closed this Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

actions ci Issues/PRs that reference CI build/test deployment::k8s Relates to dynamo deployment in kubernetes size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sttts @aprlbrnl8-cyber @tmonty12