Skip to content

fix(operator): preserve runtime versions across updates - #12195

Merged
sttts merged 16 commits into
tmonty12/dyn-940-runtime-versionfrom
sttts-pr10494-runtime-version-fixes
Jul 28, 2026
Merged

fix(operator): preserve runtime versions across updates#12195
sttts merged 16 commits into
tmonty12/dyn-940-runtime-versionfrom
sttts-pr10494-runtime-version-fixes

Conversation

@sttts

@sttts sttts commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • ratchet runtimeVersionOverride admission across DGDR, DGD, and DCD updates so unchanged legacy images remain updateable
  • require an override when an update introduces or changes a non-semver runtime image
  • allow an override-only DGDR repair while the remaining spec stays immutable
  • make the DGDR controller apply the request-level override to profiler output before persistence and again before DGD creation
  • cover v1alpha1 and v1beta1 source paths, current profiler output, and persisted legacy profiler output

This is a stacked fix for #10494 and targets tmonty12/dyn-940-runtime-version.

Linear: DYN-940

Root cause

The new create-time runtime-version requirement was applied inconsistently on updates: full revalidation trapped unchanged legacy resources, while the selected profiler image remained responsible for propagating a field that older profiler versions do not understand.

User impact

Existing resources with unchanged custom image tags remain editable, but changing to a non-semver image still requires an explicit runtime version. DGDRs using older profiler images no longer produce DGD manifests that fail admission after the request itself was accepted.

Validation

  • gofmt on all changed Go files
  • repository pre-commit hooks passed for both commits
  • git diff --check
  • GPG signatures verified for both commits
  • tests not run, per review constraint

@github-actions github-actions Bot added fix deployment::k8s Relates to dynamo deployment in kubernetes labels Jul 27, 2026
sttts
sttts commented Jul 27, 2026
View reviewed changes
Comment thread deploy/operator/internal/controller/dynamographdeploymentrequest_controller.go
sttts
sttts commented Jul 27, 2026
View reviewed changes
Comment thread deploy/operator/internal/webhook/validation/dynamocomponentdeployment.go
sttts
sttts commented Jul 27, 2026
View reviewed changes
Comment thread deploy/operator/internal/webhook/validation/dynamocomponentdeployment.go
sttts
sttts commented Jul 27, 2026
View reviewed changes
Comment thread deploy/operator/internal/webhook/validation/dynamographdeployment.go Outdated
sttts
sttts commented Jul 27, 2026
View reviewed changes
Comment thread deploy/operator/internal/webhook/validation/dynamographdeploymentrequest.go
sttts
sttts commented Jul 27, 2026
View reviewed changes
Comment thread deploy/operator/internal/webhook/validation/shared_v1alpha1.go Outdated
sttts
sttts commented Jul 27, 2026
View reviewed changes
Comment thread deploy/operator/internal/webhook/validation/shared_v1alpha1.go Outdated
sttts
sttts commented Jul 27, 2026
View reviewed changes
Comment thread deploy/operator/internal/webhook/validation/shared_v1alpha1.go Outdated
sttts
sttts commented Jul 27, 2026
View reviewed changes
Comment thread deploy/operator/internal/webhook/validation/shared_v1beta1.go Outdated
sttts
sttts commented Jul 27, 2026
View reviewed changes
Comment thread deploy/operator/internal/webhook/validation/shared_v1beta1.go Outdated
sttts
sttts commented Jul 27, 2026
View reviewed changes
Comment thread deploy/operator/internal/webhook/validation/shared_v1beta1.go Outdated
sttts
sttts commented Jul 27, 2026
View reviewed changes
Comment thread deploy/operator/internal/webhook/validation/shared_v1beta1.go Outdated
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Jul 27, 2026
@github-actions

github-actions Bot commented Jul 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🌿 Fern Docs Preview: https://nvidia-preview-019fa593-8668-7185-a015-6465c9ba4441.docs.buildwithfern.com/dynamo/dev

@sttts
sttts marked this pull request as ready for review July 27, 2026 13:59
@sttts
sttts requested a review from a team as a code owner July 27, 2026 13:59
devin-ai-integration[bot]
devin-ai-integration Bot reviewed Jul 27, 2026
View reviewed changes

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@sttts
sttts requested review from a team as code owners July 27, 2026 15:51
@datadog-official

This comment has been minimized.

Sign in to view
@sttts
sttts requested a review from a team as a code owner July 27, 2026 16:27
tmonty12
tmonty12 reviewed Jul 27, 2026
View reviewed changes

@tmonty12 tmonty12 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline review comments on the immutable repair path and runtimeVersionOverride ownership.

Comment thread deploy/operator/internal/webhook/validation/dynamographdeploymentrequest.go
Comment thread deploy/operator/internal/controller/dynamographdeploymentrequest_controller.go
Comment thread docs/fern/components/profiler/profiler-guide.md
Comment thread deploy/operator/internal/controller/dynamographdeploymentrequest_controller.go
@sttts
sttts force-pushed the tmonty12/dyn-940-runtime-version branch from 705ec3f to 58dce53 Compare July 27, 2026 20:23
@sttts
sttts requested review from a team as code owners July 27, 2026 20:23
@sttts
sttts force-pushed the sttts-pr10494-runtime-version-fixes branch 4 times, most recently from 4209446 to 39ddac3 Compare July 27, 2026 21:28
sttts added 16 commits July 27, 2026 23:52
@sttts
operator/webhook: ratchet runtime version validation
b6d1649 
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@sttts
operator/dgdr: preserve runtime versions across profilers
44ebc04 
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@sttts
fixup! operator/webhook: ratchet runtime version validation
7089ff1 
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@sttts
fixup! operator/webhook: ratchet runtime version validation
1a232ae 
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@sttts
fixup! operator/webhook: ratchet runtime version validation
3b0b3e3 
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@sttts
fixup! operator/webhook: ratchet runtime version validation
29fa502 
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@sttts
deploy/helm: sync runtime version upgrade notes
493a9d9 
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@sttts
fixup! operator/dgdr: preserve runtime versions across profilers
d219683 
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@sttts
fixup! operator/dgdr: preserve runtime versions across profilers
ef2ed55 
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@sttts
fixup! operator/dgdr: preserve runtime versions across profilers
704c608 
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@sttts
fixup! operator/dgdr: preserve runtime versions across profilers
99f738e 
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@sttts
fixup! operator/dgdr: preserve runtime versions across profilers
4d4cdc5 
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@sttts
fixup! fixup! operator/dgdr: preserve runtime versions across profilers
b54ccf5 
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@sttts
fixup! operator/webhook: ratchet runtime version validation
bb52ada 
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@sttts
fixup! operator/dgdr: preserve runtime versions across profilers
0075904 
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@sttts
fixup! operator/dgdr: preserve runtime versions across profilers
f1e7f05 
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@sttts
sttts force-pushed the sttts-pr10494-runtime-version-fixes branch from 7a6999b to f1e7f05 Compare July 27, 2026 21:52
@sttts
sttts merged commit a8aa0fd into tmonty12/dyn-940-runtime-version Jul 28, 2026
103 checks passed
@sttts
sttts deleted the sttts-pr10494-runtime-version-fixes branch July 28, 2026 08:10
sttts added a commit that referenced this pull request Jul 28, 2026
@sttts
fix(operator): preserve runtime versions across updates (#12195)
11d3da1 
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit that referenced this pull request Jul 28, 2026
@sttts
fix(operator): preserve runtime versions across updates (#12195)
bc8bd3b 
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit that referenced this pull request Jul 29, 2026
@sttts
fix(operator): preserve runtime versions across updates (#12195)
ba78ea7 
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit that referenced this pull request Jul 29, 2026
@sttts
fix(operator): preserve runtime versions across updates (#12195)
1a88aa5 
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tmonty12 tmonty12 tmonty12 left review comments
@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments
@julienmancuso julienmancuso julienmancuso approved these changes
+1 more reviewer
@dynamo-review-agent dynamo-review-agent[bot] dynamo-review-agent[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

deployment::k8s Relates to dynamo deployment in kubernetes documentation Improvements or additions to documentation fix planner size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sttts @tmonty12 @julienmancuso