Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/FILTERS.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ When you open a PR, CI checks which files changed and runs only relevant jobs:
|--------|----------|
| `core` | Main test suite (vLLM, SGLang, TRT-LLM containers) |
| `operator` | Kubernetes operator tests |
| `snapshot` | Snapshot Agent tests |
| `snapshot` | Snapshot Agent + all-framework DynamoCheckpoint deploy tests |
| `snapshot_vllm` / `snapshot_sglang` / `snapshot_trtllm` | That framework's DynamoCheckpoint deploy suite |
| `deploy` | Deploy-specific tests |
| `vllm` / `sglang` / `trtllm` | Backend-specific tests |
| `benchmarks` | Dynamo runtime pipeline (runs `tests/benchmarks/**` pytest suite) |
Expand Down
19 changes: 17 additions & 2 deletions .github/actions/changed-files/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,17 @@ outputs:
description: 'Whether operator files changed'
value: ${{ steps.filter.outputs.operator_any_modified }}
snapshot:
description: 'Whether snapshot-agent files changed'
description: 'Whether shared snapshot/DynamoCheckpoint files changed'
value: ${{ steps.filter.outputs.snapshot_any_modified }}
snapshot_vllm:
description: 'Whether vLLM snapshot lifecycle files changed'
value: ${{ steps.filter.outputs.snapshot_vllm_any_modified }}
snapshot_sglang:
description: 'Whether SGLang snapshot lifecycle files changed'
value: ${{ steps.filter.outputs.snapshot_sglang_any_modified }}
snapshot_trtllm:
description: 'Whether TRT-LLM snapshot lifecycle files changed'
value: ${{ steps.filter.outputs.snapshot_trtllm_any_modified }}
power_agent:
description: 'Whether power-agent files changed'
value: ${{ steps.filter.outputs.power_agent_any_modified }}
Expand Down Expand Up @@ -134,6 +143,9 @@ runs:
echo "core: ${{ steps.filter.outputs.core_any_modified }}"
echo "operator: ${{ steps.filter.outputs.operator_any_modified }}"
echo "snapshot: ${{ steps.filter.outputs.snapshot_any_modified }}"
echo "snapshot_vllm: ${{ steps.filter.outputs.snapshot_vllm_any_modified }}"
echo "snapshot_sglang: ${{ steps.filter.outputs.snapshot_sglang_any_modified }}"
echo "snapshot_trtllm: ${{ steps.filter.outputs.snapshot_trtllm_any_modified }}"
echo "power_agent: ${{ steps.filter.outputs.power_agent_any_modified }}"
echo "deploy: ${{ steps.filter.outputs.deploy_any_modified }}"
echo "planner: ${{ steps.filter.outputs.planner_any_modified }}"
Expand All @@ -152,6 +164,9 @@ runs:
echo "core: ${{ steps.filter.outputs.core_all_modified_files }}"
echo "operator: ${{ steps.filter.outputs.operator_all_modified_files }}"
echo "snapshot: ${{ steps.filter.outputs.snapshot_all_modified_files }}"
echo "snapshot_vllm: ${{ steps.filter.outputs.snapshot_vllm_all_modified_files }}"
echo "snapshot_sglang: ${{ steps.filter.outputs.snapshot_sglang_all_modified_files }}"
echo "snapshot_trtllm: ${{ steps.filter.outputs.snapshot_trtllm_all_modified_files }}"
echo "power_agent: ${{ steps.filter.outputs.power_agent_all_modified_files }}"
echo "deploy: ${{ steps.filter.outputs.deploy_all_modified_files }}"
echo "planner: ${{ steps.filter.outputs.planner_all_modified_files }}"
Expand All @@ -168,7 +183,7 @@ runs:
shell: bash
run: |
# Combine all filter-specific files into one list
COVERED_FILES=$(echo "${{ steps.filter.outputs.docs_all_modified_files }} ${{ steps.filter.outputs.examples_all_modified_files }} ${{ steps.filter.outputs.ignore_all_modified_files }} ${{ steps.filter.outputs.ci_all_modified_files }} ${{ steps.filter.outputs.core_all_modified_files }} ${{ steps.filter.outputs.operator_all_modified_files }} ${{ steps.filter.outputs.snapshot_all_modified_files }} ${{ steps.filter.outputs.power_agent_all_modified_files }} ${{ steps.filter.outputs.deploy_all_modified_files }} ${{ steps.filter.outputs.planner_all_modified_files }} ${{ steps.filter.outputs.vllm_all_modified_files }} ${{ steps.filter.outputs.sglang_all_modified_files }} ${{ steps.filter.outputs.trtllm_all_modified_files }} ${{ steps.filter.outputs.sample_all_modified_files }} ${{ steps.filter.outputs.frontend_all_modified_files }} ${{ steps.filter.outputs.benchmarks_all_modified_files }} ${{ steps.filter.outputs.efa_all_modified_files }} ${{ steps.filter.outputs.rust_all_modified_files }}" | tr ' ' '\n' | grep -v '^$' | sort -u)
COVERED_FILES=$(echo "${{ steps.filter.outputs.docs_all_modified_files }} ${{ steps.filter.outputs.examples_all_modified_files }} ${{ steps.filter.outputs.ignore_all_modified_files }} ${{ steps.filter.outputs.ci_all_modified_files }} ${{ steps.filter.outputs.core_all_modified_files }} ${{ steps.filter.outputs.operator_all_modified_files }} ${{ steps.filter.outputs.snapshot_all_modified_files }} ${{ steps.filter.outputs.snapshot_vllm_all_modified_files }} ${{ steps.filter.outputs.snapshot_sglang_all_modified_files }} ${{ steps.filter.outputs.snapshot_trtllm_all_modified_files }} ${{ steps.filter.outputs.power_agent_all_modified_files }} ${{ steps.filter.outputs.deploy_all_modified_files }} ${{ steps.filter.outputs.planner_all_modified_files }} ${{ steps.filter.outputs.vllm_all_modified_files }} ${{ steps.filter.outputs.sglang_all_modified_files }} ${{ steps.filter.outputs.trtllm_all_modified_files }} ${{ steps.filter.outputs.sample_all_modified_files }} ${{ steps.filter.outputs.frontend_all_modified_files }} ${{ steps.filter.outputs.benchmarks_all_modified_files }} ${{ steps.filter.outputs.efa_all_modified_files }} ${{ steps.filter.outputs.rust_all_modified_files }}" | tr ' ' '\n' | grep -v '^$' | sort -u)

# Get all modified files
ALL_FILES=$(echo "${{ steps.filter.outputs.all_all_modified_files }}" | tr ' ' '\n' | grep -v '^$' | sort -u)
Expand Down
16 changes: 15 additions & 1 deletion .github/filters.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
# Filters that trigger CI jobs:
# core -> dynamo build-test, all backend builds (vllm/sglang/trtllm)
# operator -> operator build and test
# snapshot -> snapshot-agent build and test
# snapshot -> snapshot-agent build/test + all-framework DynamoCheckpoint deploy tests
# snapshot_vllm / snapshot_sglang / snapshot_trtllm -> that framework's DynamoCheckpoint suite
# power_agent -> power-agent image build
# deploy -> deploy tests
# planner -> dynamo build-test
Expand Down Expand Up @@ -152,6 +153,19 @@ snapshot:
- 'deploy/operator/internal/checkpoint/**'
- 'tests/deploy/test_dynamocheckpoint.py'

# Framework-local snapshot lifecycle files, plus TRT-LLM's unit test. These gate
# that framework's DynamoCheckpoint deploy jobs (and shared snapshot-agent/operator
# deps) without forcing the other backends' checkpoint suites.
snapshot_vllm:
- 'components/src/dynamo/vllm/snapshot.py'

snapshot_sglang:
- 'components/src/dynamo/sglang/snapshot.py'

snapshot_trtllm:
- 'components/src/dynamo/trtllm/snapshot.py'
- 'components/src/dynamo/trtllm/tests/test_trtllm_snapshot.py'

power_agent:
- *ci
- 'deploy/power-agent/**'
Expand Down
50 changes: 50 additions & 0 deletions .github/scripts/test-filters.js
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,56 @@ const testCases = [
expect: { core: false, deploy: true },
desc: 'helm file triggers deploy'
},

// Framework snapshot lifecycle: backend filter + that framework's DynamoCheckpoint filter
{
file: 'components/src/dynamo/vllm/snapshot.py',
expect: {
vllm: true,
snapshot: false,
snapshot_vllm: true,
snapshot_sglang: false,
snapshot_trtllm: false,
},
desc: 'vllm snapshot.py gates only vllm DynamoCheckpoint'
},
{
file: 'components/src/dynamo/sglang/snapshot.py',
expect: {
sglang: true,
snapshot: false,
snapshot_vllm: false,
snapshot_sglang: true,
snapshot_trtllm: false,
},
desc: 'sglang snapshot.py gates only sglang DynamoCheckpoint'
Comment thread
galletas1712 marked this conversation as resolved.
Resolved
},
{
file: 'components/src/dynamo/trtllm/snapshot.py',
expect: {
trtllm: true,
snapshot: false,
snapshot_vllm: false,
snapshot_sglang: false,
snapshot_trtllm: true,
},
desc: 'trtllm snapshot.py gates only trtllm DynamoCheckpoint'
},
{
file: 'components/src/dynamo/trtllm/tests/test_trtllm_snapshot.py',
expect: { trtllm: true, snapshot_trtllm: true, snapshot: false },
desc: 'trtllm snapshot unit test gates only trtllm DynamoCheckpoint'
},
{
file: 'components/src/dynamo/common/snapshot/lifecycle.py',
expect: { snapshot: true, snapshot_vllm: false, core: true },
desc: 'shared snapshot lifecycle triggers shared snapshot filter'
},
{
file: 'tests/deploy/test_dynamocheckpoint.py',
expect: { snapshot: true, deploy: true },
desc: 'DynamoCheckpoint deploy test triggers shared snapshot'
},
];

// Print available filters
Expand Down
Loading
Loading